Profiler_SourcePositionOptimized flaky crash

[dcharkes]

/=============================================================================\
| vm/cc/Profiler_SourcePositionOptimized broke (Pass -> Crash, expected Pass) |
\=============================================================================/

--- Command "run_vm_unittest" (took 08.000721s):
DART_CONFIGURATION=DebugX64 xcodebuild/DebugX64/run_vm_tests --dfe=/b/s/w/ir/xcodebuild/DebugX64/gen/kernel-service.dart.snapshot --ignore-unrecognized-flags Profiler_SourcePositionOptimized

exit code:
-6

stdout:
Running test: Profiler_SourcePositionOptimized

stderr:
../../runtime/vm/thread_interrupter.h: 138: error: expected: old_value < 0
version=2.12.0-edge.b4773ae49659ea7c74b8736adcb8b6f847256207 (be) (Sat Nov 21 07:36:53 2020 +0000) on "macos_x64"
pid=25044, thread=775, isolate_group=isolate(0x7fd437817800), isolate=isolate(0x7fd437823800)
isolate_instructions=1048400e0, vm_instructions=1048400e0
  pc 0x0000000104befe74 fp 0x00007ffeeb682330 dart::Profiler::DumpStackTrace(void*)+0x64
  pc 0x00000001049a0bc2 fp 0x00007ffeeb682410 dart::Assert::Fail(char const*, ...)+0x82
  pc 0x0000000104bf732f fp 0x00007ffeeb6824d0 dart::Profile::Build(dart::Thread*, dart::SampleFilter*, dart::SampleBuffer*)+0xff
  pc 0x0000000104727e03 fp 0x00007ffeeb6852f0 dart::Dart_TestProfiler_SourcePositionOptimized()+0x3a3
  pc 0x00000001045f36ae fp 0x00007ffeeb685310 dart::TestCase::Run()+0x1e
  pc 0x00000001045f3813 fp 0x00007ffeeb685340 dart::TestCaseBase::RunTest()+0x53
  pc 0x00000001047760a7 fp 0x00007ffeeb685360 dart::TestCaseBase::RunAll()+0x27
  pc 0x00000001045f3e39 fp 0x00007ffeeb6853a0 dart::Main(int, char const**)+0x469
  pc 0x00000001045f39c9 fp 0x00007ffeeb6853b0 main+0x9
  pc 0x00007fff65eda015 fp 0x00007ffeeb6853c8 start+0x1
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartk-mac-debug-x64 vm/cc/Profiler_SourcePositionOptimized

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8863039118417609328/+/steps/test_results/0/logs/ignored_flaky_test_failure_logs/0

Assert added in https://dart-review.googlesource.com/c/sdk/+/139025

cc @rmacnak-google @bkonyi

[alexmarkov]

Other profiler tests also fail similarly:

/======================================================================================================\
| dartk-linux-debug-x64-canary:vm/cc/Profiler_BasicSourcePosition broke (Pass -> Crash, expected Pass) |
\======================================================================================================/

--- Command "run_vm_unittest" (took 06.000073s):
DART_CONFIGURATION=DebugX64 out/DebugX64/run_vm_tests --dfe=/b/s/w/ir/cache/builder/sdk/out/DebugX64/gen/kernel-service.dart.snapshot --ignore-unrecognized-flags Profiler_BasicSourcePosition

exit code:
-6

stdout:
Running test: Profiler_BasicSourcePosition

stderr:
../../runtime/vm/thread_interrupter.h: 138: error: expected: old_value < 0
version=2.12.0-edge.0f76981bb116c4ea18f12156a973b2cd5550532e (be) (Wed Jan 6 15:22:11 2021 +0000) on "linux_x64"
pid=30073, thread=30073, isolate_group=isolate(0x555faf1a5c00), isolate=isolate(0x555faf176800)
isolate_instructions=555fad5595e0, vm_instructions=555fad5595e0
  pc 0x0000555fad92e49c fp 0x00007fff32a763b0 dart::Profiler::DumpStackTrace(void*)+0x7c
  pc 0x0000555fad6dfb32 fp 0x00007fff32a76490 dart::Assert::Fail(char const*, ...)+0x82
  pc 0x0000555fad9356cf fp 0x00007fff32a76550 out/DebugX64/run_vm_tests+0x404d6cf
  pc 0x0000555fad446166 fp 0x00007fff32a79360 dart::Dart_TestProfiler_BasicSourcePosition()+0x296
  pc 0x0000555fad316d6e fp 0x00007fff32a79380 dart::TestCase::Run()+0x1e
  pc 0x0000555fad316eb3 fp 0x00007fff32a793b0 dart::TestCaseBase::RunTest()+0x53
  pc 0x0000555fad4954b7 fp 0x00007fff32a793d0 dart::TestCaseBase::RunAll()+0x27
  pc 0x0000555fad317501 fp 0x00007fff32a79460 out/DebugX64/run_vm_tests+0x3a2f501
  pc 0x0000555fad317069 fp 0x00007fff32a79470 main+0x9
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartk-linux-debug-x64-canary vm/cc/Profiler_BasicSourcePosition

/========================================================================================================\
| dartk-linux-debug-ia32-canary:vm/cc/Profiler_TypedArrayAllocation broke (Pass -> Crash, expected Pass) |
\========================================================================================================/

--- Command "run_vm_unittest" (took 06.000493s):
DART_CONFIGURATION=DebugIA32 out/DebugIA32/run_vm_tests --dfe=/b/s/w/ir/cache/builder/sdk/out/DebugIA32/gen/kernel_service.dill --ignore-unrecognized-flags Profiler_TypedArrayAllocation

exit code:
-6

stdout:
Running test: Profiler_TypedArrayAllocation

stderr:
../../runtime/vm/thread_interrupter.h: 138: error: expected: old_value < 0
version=2.12.0-edge.26805bc63631b60de9ec31049ce93f6df3e17fde (be) (Thu Jan 7 01:55:41 2021 +0000) on "linux_ia32"
pid=2686, thread=2686, isolate_group=isolate(0x559e400), isolate=isolate(0x55b6500)
isolate_instructions=3d1afe0, vm_instructions=3d1afe0
  pc 0x040b657c fp 0xff863468 dart::Profiler::DumpStackTrace(void*)+0x5c
  pc 0x045f74f4 fp 0xff863488 Dart_DumpNativeStackTrace+0x14
  pc 0x03e72deb fp 0xff8634b8 dart::Assert::Fail(char const*, ...)+0x2b
  pc 0x040bd238 fp 0xff863538 dart::Profile::Build(dart::Thread*, dart::SampleFilter*, dart::SampleBuffer*)+0xc8
  pc 0x03c2647e fp 0xff864c98 dart::Dart_TestProfiler_TypedArrayAllocation()+0x2ce
  pc 0x03b0b273 fp 0xff864cb8 dart::TestCase::Run()+0x23
  pc 0x03b0b34d fp 0xff864cf8 dart::TestCaseBase::RunTest()+0x4d
  pc 0x03c74785 fp 0xff864d18 dart::TestCaseBase::RunAll()+0x35
  pc 0x03b0b824 fp 0xff864d58 out/DebugIA32/run_vm_tests+0x370b824
  pc 0x03b0b494 fp 0xff864d78 main+0x14
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartk-linux-debug-ia32-canary vm/cc/Profiler_TypedArrayAllocation

/==========================================================================================================\
| dartk-linux-debug-ia32-canary:vm/cc/Profiler_ToggleRecordAllocation broke (Pass -> Crash, expected Pass) |
\==========================================================================================================/

--- Command "run_vm_unittest" (took 06.000972s):
DART_CONFIGURATION=DebugIA32 out/DebugIA32/run_vm_tests --dfe=/b/s/w/ir/cache/builder/sdk/out/DebugIA32/gen/kernel_service.dill --ignore-unrecognized-flags Profiler_ToggleRecordAllocation

exit code:
-6

stdout:
Running test: Profiler_ToggleRecordAllocation

stderr:
../../runtime/vm/thread_interrupter.h: 138: error: expected: old_value < 0
version=2.12.0-edge.51674dea1004fe082fd1a663b63e96ea70ee9ea2 (be) (Thu Jan 7 11:44:58 2021 +0000) on "linux_ia32"
pid=28682, thread=28682, isolate_group=isolate(0x6c94400), isolate=isolate(0x6cac500)
isolate_instructions=3d1b2a0, vm_instructions=3d1b2a0
  pc 0x040b7cbc fp 0xff96f988 dart::Profiler::DumpStackTrace(void*)+0x5c
  pc 0x045f8e74 fp 0xff96f9a8 Dart_DumpNativeStackTrace+0x14
  pc 0x03e730ab fp 0xff96f9d8 dart::Assert::Fail(char const*, ...)+0x2b
  pc 0x040be978 fp 0xff96fa58 dart::Profile::Build(dart::Thread*, dart::SampleFilter*, dart::SampleBuffer*)+0xc8
  pc 0x03c214bf fp 0xff9711a8 dart::Dart_TestProfiler_ToggleRecordAllocation()+0x2af
  pc 0x03b0b6b3 fp 0xff9711c8 dart::TestCase::Run()+0x23
  pc 0x03b0b78d fp 0xff971208 dart::TestCaseBase::RunTest()+0x4d
  pc 0x03c74bb5 fp 0xff971228 dart::TestCaseBase::RunAll()+0x35
  pc 0x03b0bc64 fp 0xff971268 out/DebugIA32/run_vm_tests+0x370bc64
  pc 0x03b0b8d4 fp 0xff971288 main+0x14
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartk-linux-debug-ia32-canary vm/cc/Profiler_ToggleRecordAllocation


/=========================================================================================\
| dartk-linux-debug-x64-canary:vm/cc/Service_Profile broke (Pass -> Crash, expected Pass) |
\=========================================================================================/

--- Command "run_vm_unittest" (took 03.000614s):
DART_CONFIGURATION=DebugX64 out/DebugX64/run_vm_tests --dfe=/b/s/w/ir/cache/builder/sdk/out/DebugX64/gen/kernel-service.dart.snapshot --ignore-unrecognized-flags Service_Profile

exit code:
-6

stdout:
Running test: Service_Profile

stderr:
../../runtime/vm/thread_interrupter.h: 138: error: expected: old_value < 0
version=2.12.0-edge.51674dea1004fe082fd1a663b63e96ea70ee9ea2 (be) (Thu Jan 7 11:44:58 2021 +0000) on "linux_x64"
pid=4319, thread=4319, isolate_group=isolate(0x563a8abe7c00), isolate=isolate(0x563a8abb8800)
isolate_instructions=563a87753de0, vm_instructions=563a87753de0
  pc 0x0000563a87b2a25c fp 0x00007ffc71807510 dart::Profiler::DumpStackTrace(void*)+0x7c
  pc 0x0000563a878da332 fp 0x00007ffc718075f0 dart::Assert::Fail(char const*, ...)+0x82
  pc 0x0000563a87b3148f fp 0x00007ffc718076b0 out/DebugX64/run_vm_tests+0x404f48f
  pc 0x0000563a87b33161 fp 0x00007ffc718077b0 dart::ProfilerService::PrintJSONImpl(dart::Thread*, dart::JSONStream*, dart::SampleFilter*, dart::SampleBuffer*, bool)+0xe1
  pc 0x0000563a87b332a0 fp 0x00007ffc71807820 dart::ProfilerService::PrintJSON(dart::JSONStream*, long, long, bool)+0xa0
  pc 0x0000563a87bb396e fp 0x00007ffc71807860 out/DebugX64/run_vm_tests+0x40d196e
  pc 0x0000563a87baf0d5 fp 0x00007ffc718079d0 dart::Service::InvokeMethod(dart::Isolate*, dart::Array const&, bool)+0x4a5
  pc 0x0000563a87bafc5e fp 0x00007ffc71807a00 dart::Service::HandleIsolateMessage(dart::Isolate*, dart::Array const&)+0x1e
  pc 0x0000563a87653c16 fp 0x00007ffc71807bd0 dart::Dart_TestService_Profile()+0x536
  pc 0x0000563a87511e6e fp 0x00007ffc71807bf0 dart::TestCase::Run()+0x1e
  pc 0x0000563a87511fb3 fp 0x00007ffc71807c20 dart::TestCaseBase::RunTest()+0x53
  pc 0x0000563a8768fee7 fp 0x00007ffc71807c40 dart::TestCaseBase::RunAll()+0x27
  pc 0x0000563a87512601 fp 0x00007ffc71807cd0 out/DebugX64/run_vm_tests+0x3a30601
  pc 0x0000563a87512169 fp 0x00007ffc71807ce0 main+0x9
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartk-linux-debug-x64-canary vm/cc/Service_Profile