Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vm/ffi] Enable FFI on Fuchsia #44434

Closed
dcharkes opened this issue Dec 9, 2020 · 0 comments
Closed

[vm/ffi] Enable FFI on Fuchsia #44434

dcharkes opened this issue Dec 9, 2020 · 0 comments
Assignees
@dcharkes
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. customer-fuchsia library-ffi os-fuchsia

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Dec 9, 2020

Opening an issue which commits can reference.

WIP: https://dart-review.googlesource.com/c/sdk/+/173273
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. os-fuchsia customer-fuchsia library-ffi labels Dec 9, 2020
@dcharkes dcharkes self-assigned this Dec 9, 2020
dart-bot pushed a commit that referenced this issue Dec 10, 2020
@dcharkes
[vm] Fuchsia arm64 build
4ccb45c 
Also runs the build on the existing Fuchsia bot and start building the
test .far on the bot.

Issue: #38752
Issue: #44434

TEST=tools/build.py --os=fuchsia -a arm64 create_sdk

Change-Id: I8ba92defb9318773552af7e178dea12460790004
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175482
Reviewed-by: Liam Appelbe <liama@google.com>
dart-bot pushed a commit that referenced this issue Dec 10, 2020
@dcharkes
[vm] Update fuchsia emulator
cae99dc 
Bump the fuchsia emulator to a version in which the arm64 emulator
does not get stuck. We don't use this anywhere on the bots, but when
running locally.

Issue: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=61157
Issue: #38752
Issue: #44434

Change-Id: I7e8fa33058f1fec06e7afcb1a579a24da8fa2fed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175483
Reviewed-by: Liam Appelbe <liama@google.com>
dart-bot pushed a commit that referenced this issue Dec 10, 2020
@dcharkes
[vm/ffi] Fuchsia FFI testing package
550d580 
This does not include enabling the FFI on Fuchsia. So these tests will
fail without the dependent CL.

This CL adds an `all_positive.dart` test file to be packaged in the
.far file, such that it is easier to run all FFI tests in one go.

We don't run tests on the bots, but we do build this test package on
the bots.

To build the .far files locally:
```
tools/build.py --os=fuchsia -m debug fuchsia_ffi_test_package
tools/build.py --os=fuchsia -m debug -a arm64 fuchsia_ffi_test_package
```

Issue: #44434

Change-Id: Iec418e0c10d77afbf811fb83151664bcc2710b99
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175484
Reviewed-by: Liam Appelbe <liama@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. customer-fuchsia library-ffi os-fuchsia
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcharkes