Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the unsigned shift, triple-shift, >>> operator in analyzer #44908

Closed
4 tasks done
srawlins opened this issue Feb 9, 2021 · 3 comments
Closed
4 tasks done

Handle the unsigned shift, triple-shift, >>> operator in analyzer #44908

srawlins opened this issue Feb 9, 2021 · 3 comments
Assignees
@srawlins
Labels
analyzer-spec Issues with the analyzer's implementation of the language spec area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Milestone
March Beta Release

Comments

@srawlins
Copy link
Member

srawlins commented Feb 9, 2021 •
edited
Loading

This is the analyzer implementation subtask under dart-lang/language#478. Broad feature here: dart-lang/language#120.

Here is the accepted feature: https://github.com/dart-lang/language/tree/master/accepted/future-releases/small-features-21Q1
@srawlins srawlins added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on analyzer-spec Issues with the analyzer's implementation of the language spec labels Feb 9, 2021
@srawlins srawlins mentioned this issue Feb 9, 2021
Closed
6 tasks
@leafpetersen leafpetersen added this to the March Beta Release milestone Feb 9, 2021
@leafpetersen leafpetersen mentioned this issue Feb 9, 2021
Closed
3 tasks
@jcollins-g jcollins-g mentioned this issue Feb 9, 2021
Closed
@srawlins srawlins self-assigned this Feb 11, 2021
@srawlins
Copy link
Member Author

After reviewing the existing lint rules, I see none which need new test cases or implementation for triple-shift.

dart-bot pushed a commit that referenced this issue Feb 12, 2021
@srawlins
Analyzer: add triple-shift constant test
337bba0 
Bug: #44908
Change-Id: If510a9aa36fa028e8f91d3cc9dd161282d2db383
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
dart-bot pushed a commit that referenced this issue Feb 17, 2021
@srawlins
Analyzer: Support const Symbol('>>>')
0897b95 
Bug: #44908
Change-Id: I7af5587317da43f79f043dd7e92976e1011935ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@franklinyow
Copy link
Contributor

Any update here?

@srawlins
Copy link
Member Author

I'll call this done. I don't think there is any analysis_server work to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
analyzer-spec Issues with the analyzer's implementation of the language spec area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
March Beta Release
Development

No branches or pull requests
3 participants
@srawlins @leafpetersen @franklinyow