Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language tests for the Q1 2021 small features release. #44926

Closed
leafpetersen opened this issue Feb 9, 2021 · 5 comments
Closed

Language tests for the Q1 2021 small features release. #44926

leafpetersen opened this issue Feb 9, 2021 · 5 comments
Assignees
@lrhn
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on
Milestone
April release (beta)

Comments

@leafpetersen
Copy link
Member

This tracks writing language tests for this feature set.

cc @lrhn @eernstg @franklinyow
@leafpetersen leafpetersen added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Feb 9, 2021
@leafpetersen leafpetersen added this to the March Beta Release milestone Feb 9, 2021
@leafpetersen leafpetersen mentioned this issue Feb 9, 2021
Closed
16 tasks
@leafpetersen
Copy link
Member Author

Making a note that we may need additional test coverage for any spec updates based on this issue.

@leafpetersen
Copy link
Member Author

cc @srawlins @stefantsov @johnniwinther @scheglov @devoncarew for visibility on anything landed here.

@eernstg
Copy link
Member

eernstg commented Feb 25, 2021

Note that @lrhn did much of this work already:

Landed: https://dart-review.googlesource.com/c/sdk/+/180844 adds tests for dart-lang/language#496, https://dart-review.googlesource.com/c/sdk/+/180843 adds tests for dart-lang/language#120.

Under review: https://dart-review.googlesource.com/c/sdk/+/185583 adds tests for dart-lang/language#1297.

@nshahan nshahan mentioned this issue Mar 16, 2021
Closed
@leafpetersen
Copy link
Member Author

I think we seriously need some more test coverage here. There are no static error tests at all that I see in the language directory for this. c.f. #45394 for an issue found accidentally.

@leafpetersen
Copy link
Member Author

It would also be good to get more runtime type test coverage for this, e.g. tests that casts to generic type parameters work correctly (both pass when appropriate, and throw when appropriate) when the parameter is instantiated with a generic function.

dart-bot pushed a commit that referenced this issue Mar 20, 2021
@scheglov
Issue 44926. Fix checking generic function type arguments for conform…
9fc9088 
…ing bounds.

Bug: #44926
Change-Id: I92209fc4839c7d286f5efc5d9deb05e47e6cf017
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@franklinyow franklinyow added the P2 A bug or feature request we're likely to work on label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
April release (beta)
Development

No branches or pull requests
4 participants
@lrhn @leafpetersen @eernstg @franklinyow