Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web eval fails on renamed symbols #44933

Closed
vsmenon opened this issue Jun 10, 2020 · 5 comments
Closed

web eval fails on renamed symbols #44933

vsmenon opened this issue Jun 10, 2020 · 5 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-eval evaluation support on the web

Comments

@vsmenon
Copy link
Member

vsmenon commented Jun 10, 2020

@annagrin - I think this is a known issue with remapping, but didn't see an existing bug.

> 'hello'.substring(1)
ReferenceError: $substring is not defined
@vsmenon vsmenon changed the title dwds: eval fails on renamed expressions dwds: eval fails on renamed symbols Jun 10, 2020
@annagrin annagrin self-assigned this Jun 18, 2020
@grouma
Copy link
Member

grouma commented Feb 9, 2021

cc @nshahan @sigmundch

We should raise the priority on this one. Another example:

> _someMap.keys
ReferenceError: $keys is not defined

@sigmundch
Copy link
Member

Thanks! As discussed offline, seems like @annagrin is making progress towards fixing this. Since this is mostly on the ddc side of things, I'll transfer the issue to the sdk repo.

@sigmundch sigmundch transferred this issue from dart-lang/webdev Feb 10, 2021
@sigmundch sigmundch added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-eval evaluation support on the web labels Feb 10, 2021
@sigmundch sigmundch added this to the March Beta Release milestone Feb 10, 2021
@sigmundch sigmundch changed the title dwds: eval fails on renamed symbols web eval fails on renamed symbols Feb 10, 2021
@sigmundch
Copy link
Member

@annagrin - is this also covered by #40273?

@annagrin
Copy link
Contributor

@vsmenon @sigmundch this issue seems to be due to a missing symbol definition in JavaScript for the evaluated function. I added a link (above) to the issue that should cover loading and redefining variables for all used libraries, symbols, types, uris, and constants in the synthetic evaluation function. This also will enable evaluate() implementation that is needed for flutter's widget inspector. I am working on it currently, for the amd module format only at the moment.

@sigmundch
Copy link
Member

Thanks for the update, I'll comment on the other bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-eval evaluation support on the web
Projects
None yet
Development

No branches or pull requests

4 participants