Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics flags do not work correctly in dev branches #44968

Closed
mit-mit opened this issue Feb 11, 2021 · 4 comments
Closed

Analytics flags do not work correctly in dev branches #44968

mit-mit opened this issue Feb 11, 2021 · 4 comments
Assignees
@bkonyi
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. P0 A serious issue requiring immediate resolution
Milestone
January Beta Rele...

Comments

@mit-mit
Copy link
Member

mit-mit commented Feb 11, 2021 •
edited

In current stable, the --enable-analytics and --disable-analytics flags print output like this:

$ ./stable/dart-sdk/bin/dart --disable-analytics
  ╔════════════════════════════════════════════════════════════════════════════╗
  ║ Anonymous analytics disabled. To enable again, run the command:            ║
  ║ `dart --enable-analytics`                                                  ║
  ╚════════════════════════════════════════════════════════════════════════════╝

In the current dev & beta channels, it just prints help:

$ ./dart --disable-analytics
A command-line utility for Dart development.

Usage: dart [<vm-flags>] <command|dart-file> [<arguments>]

Thanks to @iamchathu for reporting via dart-lang/site-www#2765 (comment)
@mit-mit mit-mit added area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. P0 A serious issue requiring immediate resolution labels Feb 11, 2021
@mit-mit mit-mit added this to the February Beta Release milestone Feb 11, 2021
@mit-mit mit-mit mentioned this issue Feb 11, 2021
Merged
@mit-mit
Copy link
Member Author

mit-mit commented Feb 11, 2021

cc @bkonyi @a-siva @devoncarew

@iamchathu
Copy link

iamchathu commented Feb 11, 2021 •
edited

I got this issue too. I'm using flutter SDK on beta channel

@bkonyi
Copy link
Contributor

bkonyi commented Feb 11, 2021

Looks like this was broken in f3fe9dc#diff-d2c73d2163def9f30c2610b1c47804f258a27bb96abc731ce4eeadfe778333f6L516.

@a-siva
Copy link
Contributor

a-siva commented Feb 11, 2021

https://dart-review.googlesource.com/c/sdk/+/184502 from @bkonyi

@bkonyi bkonyi mentioned this issue Feb 11, 2021
Closed
@a-siva a-siva mentioned this issue Feb 11, 2021
Closed
dart-bot pushed a commit that referenced this issue Feb 12, 2021
@bkonyi @athomas
[ DartDev / CLI ] Fixed issue where analytics flags were not being fo…
85ca3ec 
…rwarded to the CLI

Forwarding logic seems to have been accidentally removed in
f3fe9dc.

Fixes #44968

TEST=pkg/dartdev/test/analytics_test.dart

Fixed: 44968
Change-Id: Ib3c107233276ca6592247e23268f9af7ede52285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184502
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. P0 A serious issue requiring immediate resolution
Projects
None yet
Milestone
January Beta Release (2.12)
Development

No branches or pull requests
5 participants
@iamchathu @a-siva @mit-mit @bkonyi @pcsosinski