Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DirectoryEntry and similar classes in dart:html to new class names #45036

Closed
srujzs opened this issue Feb 17, 2021 · 2 comments
Closed

Rename DirectoryEntry and similar classes in dart:html to new class names #45036

srujzs opened this issue Feb 17, 2021 · 2 comments
Assignees
@srujzs
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries

Comments

@srujzs
Copy link
Contributor

srujzs commented Feb 17, 2021 •
edited
Loading

Chromium has changed the native type name for these classes (Entry, DirectoryEntry, DirectoryReader, etc.) to prepend FileSystem over concerns about those original names in the global scope. These classes have not been updated in dart:html, and as such, the native type fails to be intercepted.

They need to be renamed and refactored to use the updated native type names.

Context: https://bugs.chromium.org/p/chromium/issues/detail?id=652814
@srujzs srujzs added web-libraries Issues impacting dart:html, etc., libraries library-html area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Feb 17, 2021
@srujzs srujzs self-assigned this Feb 17, 2021
This was referenced Feb 19, 2021
Closed
Open
@srujzs srujzs mentioned this issue Nov 30, 2021
Closed
@xfoldvar
Copy link

ping

@srujzs
Copy link
Contributor Author

srujzs commented Dec 21, 2021

Have a CL changing the bindings, currently testing, and I'll report back when it's reviewed and landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srujzs srujzs

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfoldvar @srujzs