Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive from import_deferred_library_with_load_function #45141

Closed
bwilkerson opened this issue Feb 27, 2021 · 1 comment
Closed

False positive from import_deferred_library_with_load_function #45141

bwilkerson opened this issue Feb 27, 2021 · 1 comment
Assignees
@scheglov
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@bwilkerson
Copy link
Member

Given a file a.dart containing

void loadLibrary(Library library) {}

class Library {}

and a second file containing

import 'a.dart' deferred as a hide loadLibrary;

void f() {
  a.Library();
}

the analyzer produces a HintCode.import_deferred_library_with_load_function diagnostic. The function from the imported library is hidden, so there is no conflict.
@bwilkerson bwilkerson added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes labels Feb 27, 2021
@scheglov scheglov self-assigned this Mar 5, 2021
@scheglov scheglov added the P3 A lower priority bug or feature request label Mar 5, 2021
@scheglov
Copy link
Contributor

scheglov commented Mar 5, 2021

https://dart-review.googlesource.com/c/sdk/+/189320

dart-bot pushed a commit that referenced this issue Mar 5, 2021
@scheglov
Issue 45141. Check for loadLibrary() using namespace.
3f5694c 
Bug: #45141
Change-Id: Ifb0825d66a560d0136873942f9666d3dc630b6c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov scheglov closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @bwilkerson