Bound checking errors in small features

[johnniwinther]

These tests fail due to discrepancies wrt. bound checking:

language/generic/generic_function_type_argument_test
co19/Language/Generics/Superbounded_types/typedef3_A01_t06/01
co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02
co19/Language/Generics/typedef_A06_t04
co19/Language/Generics/typedef_A06_t12
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t04
co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01
co19/LanguageFeatures/regression/34560_t02

[chloestefantsova]

• I think co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 shouldn't be a compile-time error: it's a case of a super-bounded type.
• co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03 complains about an unexpected compile-time error, but I think it should be reported.
• co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t04 seems that the errors are expected; although, the location of one of the three errors is different for Analyzer and the CFE because the CFE can't point inside of types yet. I guess the test should be updated adjusting the locations of the errors.
• co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01 complains about an unexpected compile-time error, but I think it should be reported.

[leafpetersen]

Sorry, @stefantsov I'm not sure I totally parsed which of your examples were problems with tests and which were CFE issues.

I think you're saying the last three are bad tests, but the first is ok?

[chloestefantsova]

@leafpetersen I think all four are issues with tests, and in the first one in the list a compile-time error is expected in the test, but I believe that it's not an error. Sorry for not being clear.

[chloestefantsova]

cc @eernstg

[chloestefantsova]

• Also, I think the test co19/Language/Generics/typedef_A06_t04 should be corrected too. The right-hand side of the typedef there is a regular-bounded type (it's not even an application of a generic type to type arguments), and all parts of it are well-bounded.

[eernstg]

Taking a look, I can't verify two of the issues, but I agree on the remaining ones:

• Agree: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 is not a compile-time error, B<A<A<A<B<A<dynamic>>>>>> is super-bounded.
• Can't verify the problem with co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03, it has no failures according to https://dart-ci.firebaseapp.com/current_results/#/filter=co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t03&showAll
• Agree: co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01 does look like it's just the location associated with the error message that differs for the CFE.
• Can't verify the problem with co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l4_t01.
• Agree on co19/Language/Generics/typedef_A06_t04 as well.

So maybe the 2nd and 4th issue have been fixed in a roll already?

[chloestefantsova]

I filed a co19 issue for the three tests that we agree should be updated: dart-lang/co19#1029.

[chloestefantsova]

Some of the remaining test failures are being worked on here: https://dart-review.googlesource.com/c/sdk/+/192146.

[eernstg]

About co19/Language/Generics/typedef_A06_t04: The front end does not report the error about the raw bound, but this is covered by #42435.

[chloestefantsova]

I have a status update for the remaining tests that are currently failing if run locally at the HEAD fo Dart SDK:

• co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 — still marked as compile-time error, but shouldn't be; the test should be updated;
• co19/Language/Generics/typedef_A06_t04 — the fix is in work at https://dart-review.googlesource.com/c/sdk/+/193662;
• co19/Language/Generics/typedef_A06_t12 — the fix is in work at https://dart-review.googlesource.com/c/sdk/+/193662;
• co19/LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/nonfunction_l1_t04 — still a failure because of the error locations; the locations should be updated in the test.

So, after https://dart-review.googlesource.com/c/sdk/+/193662 lands, the issue for the CFE may be closed.

[chloestefantsova]

https://dart-review.googlesource.com/c/sdk/+/193662 landed. I'm closing the issue. Please reopen if needed.