Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient profiling code isn't removed in product mode #45469

Closed
bkonyi opened this issue Mar 25, 2021 · 1 comment
Closed

HttpClient profiling code isn't removed in product mode #45469

bkonyi opened this issue Mar 25, 2021 · 1 comment
Assignees
@brianquinlan
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-_http

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Mar 25, 2021

We've seen some regressions in code size benchmarks for product mode (Flutter release mode) which are likely caused by HTTP profiling code not being tree shaken out even though it's effectively useless without a VM service. We should wrap code referencing the profiler with product mode checks to allow for this code to be tree shaken.
@bkonyi bkonyi added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-_http labels Mar 25, 2021
@bkonyi bkonyi self-assigned this Mar 25, 2021
@bkonyi bkonyi assigned brianquinlan and unassigned bkonyi Mar 15, 2023
@bkonyi
Copy link
Contributor Author

bkonyi commented Mar 15, 2023

FYI @brianquinlan, since you're poking around this code. AFAIK we're not treeshaking this code in product mode still, so maybe there's some low hanging fruit for core library size reductions.

copybara-service bot pushed a commit that referenced this issue Aug 30, 2023
@rmacnak-google
[standalone, io] Don't register service extensions in product mode.
54faa31 
dart2js.aot.x64 20942544 -> 20852448 (-90k)

TEST=ci
Bug: #45469
CoreLibraryReviewExempt: VM-only
Change-Id: I5ee6a4019af1fa4a0815ac05a42bb4883d74d8a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323503
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-_http
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmacnak-google @brianquinlan @bkonyi