Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [vm/compiler] Change when parents of local functions are retained. #45483

Closed
aam opened this issue Mar 26, 2021 · 3 comments
Closed

Failures on [vm/compiler] Change when parents of local functions are retained. #45483

aam opened this issue Mar 26, 2021 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@aam
Copy link
Contributor

aam commented Mar 26, 2021 •
edited
Loading

There are new test failures on [vm/compiler] Change when parents of local functions are retained..

The tests

pkg/vm_snapshot_analysis/test/instruction_sizes_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-mac

 'package:vm_snapshot_analysis/v8_profile.dart': Failed assertion: line 470 pos 12: 'parent != null': Trying to create node of type NodeType.functionNode with <anonymous closure @170> and no parent.

cc @sstrickl
@aam aam added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Mar 26, 2021
@a-siva
Copy link
Contributor

a-siva commented Mar 26, 2021

/cc @sstrickl

@sstrickl
Copy link
Contributor

Ah, yep, I'll need to look into how artificial nodes are added for WSRed owners and do the same for parent functions in ClosureData. Looking into that now.

@sstrickl
Copy link
Contributor

Will be fixed once https://dart-review.googlesource.com/c/sdk/+/193303 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sstrickl @aam @a-siva