No fix-all quick-fix for "Remove the !"

[DanTup]

In this (contrived) code I have multiple ! operators:

foo(String? aaa) => aaa == '' ? aaa!.length : aaa!.length;

If I update aaa to no longer be nullable, I get two reports of "The '!' will have no effect" and have to fix them individually, (though the original LSP fix-all code produced a fix-all for it).

There's an argument that you may want to review each case of this and not fix-all, but having a fix-all doesn't mean you have to use it. In the case where you've just introduced a bunch of these because you were removing null from some variables, it seems useful to be able to just do them all in one go (and with a good editor or source control, it's fairly easy to see exactly what was changed).

I don't feel strongly about this, but I thought it was worth querying.

@pq

[pq]

/fyi @bwilkerson -- I think we talked about this case?

[bwilkerson]

Possibly, but I don't remember the details. It seems reasonable to me to allow the fix to be applied everywhere; a diagnostic will only be produced where it's required to be removed.

[pq]

I can't remember the whole conversation either... I'll add this one. Thanks @DanTup !