Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible VM changes after refactor of how Constants are included in dill #45903

Closed
jensjoha opened this issue May 4, 2021 · 1 comment
Closed

Possible VM changes after refactor of how Constants are included in dill #45903

jensjoha opened this issue May 4, 2021 · 1 comment
Assignees
@dcharkes
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@jensjoha
Copy link
Contributor

jensjoha commented May 4, 2021

After https://dart-review.googlesource.com/c/sdk/+/196925 landed (and assuming it sticks), the VM can:

  • Avoid using a map but use a list instead (like the dart side).
  • Cache the start of the constant table in the reader.

See the CL for a little extra detail.
@mkustermann mkustermann added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label May 4, 2021
@mkustermann
Copy link
Member

@dcharkes Could you look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcharkes @mkustermann @jensjoha