Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfe] Implement constructor tearoffs support in the CFE #46232

Closed
eernstg opened this issue Jun 3, 2021 · 3 comments
Closed

[cfe] Implement constructor tearoffs support in the CFE #46232

eernstg opened this issue Jun 3, 2021 · 3 comments
Assignees
@chloestefantsova
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
Constructor tear-offs

Comments

@eernstg
Copy link
Member

eernstg commented Jun 3, 2021 •
edited
Loading

This issue tracks support of the constructor tearoffs feature. See the enclosing meta-issue for details.
@eernstg eernstg added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Jun 3, 2021
@eernstg eernstg mentioned this issue Jun 3, 2021
Closed
20 tasks
@franklinyow franklinyow added this to To do in Constructor tear-offs via automation Jun 3, 2021
Constructor tear-offs automation moved this from To do to Done Jul 26, 2021
@eernstg eernstg mentioned this issue Jul 29, 2021
Closed
@eernstg
Copy link
Member Author

eernstg commented Sep 8, 2021

NB: One part of this feature has not yet been implemented, I created #47147 in order to handle that.

@eernstg
Copy link
Member Author

eernstg commented Sep 8, 2021

@stefantsov, I thought about reopening this issue instead, please do that if needed.

@johnniwinther johnniwinther reopened this Sep 20, 2021
Constructor tear-offs automation moved this from Done to In progress Sep 20, 2021
copybara-service bot pushed a commit that referenced this issue Sep 23, 2021
@johnniwinther
[cfe] Handle potentially constant types in instantiations
2fa8923 
Part of #46232

Closes #47154

Change-Id: I71fe16d26facf29bdae1b98971c4ccfe18f95e80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213772
Reviewed-by: Chloe Stefantsova <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 4, 2021
@johnniwinther
[cfe] Support implicit tear off in explicit instantiation
5574b1e 
Part of #46232

Change-Id: I578ae9d78dd71da40630a3d6da75c4344876944b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215021
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <dmitryas@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 5, 2021
@johnniwinther
[cfe] Handle nullable function types in explicit instantiation
74fd108 
Part of #46232

Change-Id: I390dc15a253cf0b335ed41bf945bbab2a3b2bdcc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215545
Reviewed-by: Chloe Stefantsova <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 7, 2021
@johnniwinther
[cfe] Report error on 'new' used invalidly as selector
9603871 
Part of #46232

Closes #47075

Change-Id: I6aece2236d6f45ec50bda3622b133c16761dd990
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215764
Reviewed-by: Chloe Stefantsova <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
@johnniwinther
Copy link
Member

This seems to be complete.

Constructor tear-offs automation moved this from In progress to Done Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
Constructor tear-offs
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chloestefantsova @eernstg @johnniwinther