Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement double toStringAsExponential, toStringAsPrecision, toRadixString #463

Closed
ghost opened this issue Nov 15, 2011 · 5 comments
Closed

Implement double toStringAsExponential, toStringAsPrecision, toRadixString #463

ghost opened this issue Nov 15, 2011 · 5 comments
Assignees
@floitschG
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@ghost
Copy link

ghost commented Nov 15, 2011

LibTest/core/double/toRadixString/double/toRadixString/A01/t01: Fail
LibTest/core/double/toStringAsExponential/double/toStringAsExponential/A01/t01: Fail
LibTest/core/double/toStringAsPrecision/double/toStringAsPrecision/A01/t01: Fail
@iposva-google
Copy link
Contributor

Added Accepted label.

@ghost
Copy link
Author

ghost commented Feb 22, 2012

Missing C++ implementation in double_conversions.cc

Set owner to @floitschG.

@floitschG
Copy link
Contributor

Fixed in r4681.

Added Fixed label.

@floitschG
Copy link
Contributor

I opened a new bug for the missing toRadixString: issue #1896

@DartBot
Copy link

DartBot commented Aug 10, 2012

This comment was originally written by rodion...@unipro.ru

methods not documented

@ghost ghost added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Aug 10, 2012
@ghost ghost assigned floitschG Aug 10, 2012
nex3 pushed a commit that referenced this issue Aug 31, 2016
refactor/simplify nullable inference code
67b2493 
Some of the high level changes are:
* visit catch body, fixes #463
* handle temps created by the compiler. These were in some cases treated incorrectly as non-null (see tests diff)
* compute nullable in the same pass as visiting assignments
* simplify visiting += and ++, fix ++ (it was dead code, #463)
* simplify _isNullable
* if we fail to see a variable declaration, treat it as nullable
* stack trace in catch is treated as non-null

R=vsm@google.com

Review URL: https://codereview.chromium.org/1751963002 .
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
dart-bot pushed a commit that referenced this issue Dec 8, 2020
@athomas
[co19] Roll co19 to d8e25398102add0ac1e732850928bd44c78f2447
794d564 
2020-12-06 sgrekhov@unipro.ru Fixes #972. Remove nnbd-strong flag from static Subtyping tests
2020-12-04 irina.arkhipets@gmail.com Fixes #973: `SharedOptions=--enable-experiment=triple-shift` tag removed from the tests.
2020-12-04 irina.arkhipets@gmail.com Issue #972: needless `Requirements=nnbd-strong` tag removed.
2020-12-04 irina.arkhipets@gmail.com Issue #972: `Requirements=nnbd-strong` tags removed from the following LanguageFeatures/nnbd tests: tripple-shift, type-aliases, type-normalization.
2020-12-04 irina.arkhipets@gmail.com Issue #972: `Requirements=nnbd-strong` tags removed from LanguageFeatures/nnbd/ovrriding tests.
2020-12-04 irina.arkhipets@gmail.com Issue #972: `Requirements=nnbd-strong` tags remoed from LanguqgeFeatures/nnbd/Least-greatest-closure/nonfunction_typedef tests. Duplicated nonfunction)typedef tests removed.
2020-12-04 irina.arkhipets@gmail.com Issue #972: `Requirements=nnbd-strong` tags remoed from LanguqgeFeatures/nnbd/Least-greatest-closure/class, LanguqgeFeatures/nnbd/Least-greatest-closure/nonfunction_typedef tests.
2020-12-04 irina.arkhipets@gmail.com Issue #972: `Requirements=nnbd-strong` tags remoed from LanguqgeFeatures/nnbd/flow-analysis tests.
2020-12-04 irina.arkhipets@gmail.com Issue #463: Missing Requirements=nnbd-strong tags added.
2020-12-03 irina.arkhipets@gmail.com Fix for the Issue #972: `Requirements=nnbd-strong` removed from LanguageFeatures/nnbd tests (without subdirectories)
2020-12-02 sgrekhov@unipro.ru Cross Origin Error for HttpRequest tests fixed
2020-12-02 irina.arkhipets@gmail.com Typo corrected.
2020-12-01 sgrekhov@unipro.ru Test that use tripple shift operation moved to tripple-shift directory

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I5f19e8ddc738713b2339cae22d1d1925e35b1da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175242
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Jan 25, 2021
@athomas
[co19] Roll co19 to 103d027d38472f9871b66fb0c2b01cc91c858c9f
a828308 
2021-01-24 irina.arkhipets@gmail.com Issue #983: Static warning checks corrected.
2021-01-22 irina.arkhipets@gmail.com Issue #983: triple-shift folders re-named correctly, typo in the library paths updated for 2 tests.
2021-01-21 sgrekhov@unipro.ru Fixes #985. LateInitializationError removed
2021-01-20 sgrekhov@unipro.ru Fixes #982. Add tests for The future value type of an asynchronous non-generator function part of NNBD spec
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-normalization tests for weak mode added.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-aliases tests for weak mode added.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tripple-shift tests for weak mode added.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added for the override checkings.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures).
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures).
2021-01-18 sgrekhov@unipro.ru Fixes #981. Add tests for Return statements part of NNBD spec
2021-01-18 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode corrected according to the current Spec changes.
2021-01-14 irina.arkhipets@gmail.com Issue #462: Additional comments regarding the constant evaluation issues added to weak mode tests.
2021-01-14 sgrekhov@unipro.ru Fixes #980. Remove warnings expectations for overriding default values of optional parameters tests
2021-01-13 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak/flow-analysis directory.
2021-01-12 sgrekhov@unipro.ru #978. Weak mode test changes
2021-01-12 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak directory.
2021-01-11 sgrekhov@unipro.ru Fixes #978. Tests updated according to the "flow analysis boolean variable" feature
2020-12-25 irina.arkhipets@gmail.com Issues #463: Tests for weak mode added.
2020-12-25 irina.arkhipets@gmail.com Issues #462, #463: Moved or added new nnbd tests for weak mode, added new tests for strong mode.
2020-12-24 sgrekhov@unipro.ru #970. Usr correct values for ProcessSignal.sigusr1 and ProcessSignal.sigusr2 on Mac
2020-12-24 irina.arkhipets@gmail.com Issue #462: 1. Added nnbd tests for weak mode: exports_*, expression_typing_*, extension_method_resolution_*, future_flattening_*. 2. Moved and re-factored nnbd extension_method_resolution_*, future_flattening_* tests for weak mode into weak folder. 3. Copyrights updated Issue #463: Two exports* tests for strong mode added.
2020-12-24 sgrekhov@unipro.ru Fixes #496. Change tested date to 1 second instead of 1 day to reduce probability to change timezone on DST
2020-12-23 sgrekhov@unipro.ru Fixes #473. Remove UtilsHtml directory
2020-12-23 irina.arkhipets@gmail.com Fix for Issue #462: 1. Added nnbd tests for weak mode: assignability_*, const_evaluation_*, const_objects_*, const_type_var_elimination_*. 2. Moved and re-factored nnbd exports_* tests for weak mode into weak folder.
2020-12-10 sgrekhov@unipro.ru Fixes #976. Remove obsolete errors expectations
2020-12-10 sgrekhov@unipro.ru Fixes #975. Fix wrong expected compile time error type
2020-12-07 sgrekhov@unipro.ru Flag Requirements=nnbd-weak added to the tests that run legacy code

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I69acc5c0a28fd2e7a2d38f6c9062e5a5854bdfa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180823
Reviewed-by: William Hesse <whesse@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 11, 2022
@devoncarew
[deps] rev collection, glob, intl, markdown, stack_trace, test_descri…
b62cfff 
…ptor, webdev

collection (https://github.com/dart-lang/collection/compare/414ffa1..ca45fc4):
  ca45fc4  2022-10-07  Devon Carew  update CI config; prep for publishing (#251)

glob (https://github.com/dart-lang/glob/compare/1d51fcc..ee81279):
  ee81279  2022-10-10  Moritz  Merge pull request #62 from dart-lang/bump_deps
  b6747a1  2022-10-10  moritz  Add changelog entry
  d069e13  2022-10-10  moritz  Bump depencies

intl (https://github.com/dart-lang/intl/compare/7639a15..dda8ade):
  dda8ade  2022-10-10  Moritz  GitHub Sync (#501)

markdown (https://github.com/dart-lang/markdown/compare/f387340..d72ae07):
  d72ae07  2022-10-07  Sam Rawlins  Use fewer empty lists; non-growable (#463)

stack_trace (https://github.com/dart-lang/stack_trace/compare/17f09c2..2194227):
  2194227  2022-10-10  Kevin Moore  A bunch of cleanup, prepare for v1.11.0 (#118)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/f392f85..66f14ce):
  66f14ce  2022-10-07  Devon Carew  update the CI configuration; prep for publishing (#44)

webdev (https://github.com/dart-lang/webdev/compare/7416956..69aac60):
  69aac60  2022-10-07  Parker Lougheed  Update min SDK restraint mentioned to match pubspec (#1755)
  b175072  2022-10-07  Elliott Brooks (she/her)  Start migration of WebDev to null-safety (#1756)

Change-Id: I452b89a44cfcb7b0d9f36eeb1539ea362b29b6b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263521
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floitschG floitschG

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iposva-google @floitschG @DartBot