Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on [infra] Add xcodebuild/...XARM64 directories to the vm-kernel fileset #46306

Open
sstrickl opened this issue Jun 9, 2021 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening

Comments

@sstrickl
Copy link
Contributor

sstrickl commented Jun 9, 2021

There are new test failures on [infra] Add xcodebuild/...XARM64 directories to the vm-kernel fileset.

The test

standalone_2/check_for_aot_snapshot_jit_test RuntimeError (expected Pass)

is failing on configurations

dartk-mac-release-arm64

The log:

--- Command "vm" (took 14.000917s):
DART_CONFIGURATION=ReleaseXARM64 xcodebuild/ReleaseXARM64/dart --ignore-unrecognized-flags --packages=/opt/s/w/ir/.packages /opt/s/w/ir/tests/standalone_2/check_for_aot_snapshot_jit_test.dart

exit code:
255

stdout:
Running pkg/vm/tool/gen_kernel --aot --platform=xcodebuild/ReleaseXARM64/vm_platform_strong.dill -o /opt/s/w/itGxfEav/aot_tmp2Tn2Kq/pow_test.dill /opt/s/w/ir/tests/standalone_2/pow_test.dart...
Ran successfully.

Running xcodebuild/ReleaseXARM64/gen_snapshot --snapshot_kind=app-aot-elf --elf=/opt/s/w/itGxfEav/aot_tmp2Tn2Kq/pow_test.aot /opt/s/w/itGxfEav/aot_tmp2Tn2Kq/pow_test.dill...

stderr:
Unhandled exception:
ProcessException: No such file or directory
  Command: xcodebuild/ReleaseXARM64/gen_snapshot --snapshot_kind=app-aot-elf --elf=/opt/s/w/itGxfEav/aot_tmp2Tn2Kq/pow_test.aot /opt/s/w/itGxfEav/aot_tmp2Tn2Kq/pow_test.dill
#0      _ProcessImpl._runAndWait (dart:io-patch/process_patch.dart:476:7)
#1      _runNonInteractiveProcessSync (dart:io-patch/process_patch.dart:619:18)
#2      Process.runSync (dart:io-patch/process_patch.dart:66:12)
#3      runAndPrintOutput (file:///opt/s/w/ir/tests/standalone_2/check_for_aot_snapshot_jit_test.dart:68:26)
#4      main (file:///opt/s/w/ir/tests/standalone_2/check_for_aot_snapshot_jit_test.dart:38:24)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283:19)
#6      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python3 tools/test.py -n dartk-mac-release-arm64 standalone_2/check_for_aot_snapshot_jit_test

This is a dartk bot that builds runtime_kernel, so gen_snapshot should be available.

/cc @athomas

@sstrickl sstrickl added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening labels Jun 9, 2021
@athomas
Copy link
Member

athomas commented Jun 9, 2021

Note that the test is already failing in various ways across many configs:
https://dart-ci.firebaseapp.com/current_results/#/filter=standalone_2/check_for_aot_snapshot_jit_test

@athomas
Copy link
Member

athomas commented Jun 9, 2021

For some reason, gen_snapshot is only in xcodebuild/ReleaseXARM64/clang_x64/ but not in xcodebuild/ReleaseXARM64/ (unlike dart which exists in both places):
[3286/3517] LINK clang_x64/gen_snapshot

@sstrickl
Copy link
Contributor Author

sstrickl commented Jun 9, 2021

Note that the test is already failing in various ways across many configs:
https://dart-ci.firebaseapp.com/current_results/#/filter=standalone_2/check_for_aot_snapshot_jit_test

For sure, and these errors need to be addressed also (in fact, may do so now), just noting that the failure case here is different than in the other cases and so is worth highlighting :)

@sstrickl
Copy link
Contributor Author

sstrickl commented Jun 9, 2021

(Well, the non-IA32 failures should be addressed, and the test should probably be marked skip on IA32 since there's no AOT mode there.)

@sstrickl
Copy link
Contributor Author

sstrickl commented Jun 9, 2021

Working on fixes in https://dart-review.googlesource.com/c/sdk/+/202923.

@sstrickl sstrickl self-assigned this Jun 9, 2021
dart-bot pushed a commit that referenced this issue Jun 9, 2021
* Skip on IA32, since it has no AOT mode.

* Use .bat/.exe suffixes on Windows.

* Look for gen_snapshot in <buildDir>/clang_x64 on MacOS ARM64.

* Avoid using Platform.script to find .dart source file locations, since
  some architectures generate a .dill for running JIT programs, which
  will be in the generated files directory, not the SDK directory.

* Try both 'dart <aotsnapshot>' and 'dart run <aotsnapshot>', which
  should both give the correct error message.

Cq-Include-Trybots: luci.dart.try:vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-linux-release-x64-try,vm-kernel-linux-release-ia32-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-win-release-ia32-try,vm-kernel-win-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-mac-release-arm64-try,vm-kernel-mac-release-x64-try,vm-kernel-nnbd-mac-release-x64-try
Change-Id: Ic50b86fb51b5f2b30c6a4cb4fd8f0594bb1cf93d
Bug: #46306
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202923
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

2 participants