Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Enhanced Enums feature in the CFE #47453

Closed
Tracked by #47849
chloestefantsova opened this issue Oct 13, 2021 · 3 comments
Closed
Tracked by #47849

Implement Enhanced Enums feature in the CFE #47453

chloestefantsova opened this issue Oct 13, 2021 · 3 comments
Assignees
@chloestefantsova
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool)
Projects
enhanced-enums

Comments

@chloestefantsova
Copy link
Contributor

chloestefantsova commented Oct 13, 2021 •
edited by devoncarew

This issue is for implementing dart-lang/language#158 in the CFE and referencing it in the related CLs.

See #47849 for the main tracking issue.
@chloestefantsova chloestefantsova added area-front-end Use area-front-end for front end / CFE / kernel format related issues. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) labels Oct 13, 2021
@chloestefantsova chloestefantsova self-assigned this Oct 13, 2021
copybara-service bot pushed a commit that referenced this issue Oct 14, 2021
Add "enhanced-enums" experiment flag
cfa5d6c 
Part of #47453.

Change-Id: I6d1fdc4bc170354985a9d216b13ad8f153717adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216662
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <dmitryas@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 3, 2021
@chloestefantsova
[parser][analyzer][cfe] Add parsing support for enhanced enums
312eb81 
Part of #47453.

Change-Id: I3a722cbcca6323b751eb3b2429bb9ffb642972b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217011
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
@devoncarew
Copy link
Member

@chloestefantsova - did you mean this to be a general 'implement enhanced enums' issue, or just specific to the CFE? I started #47849 but then saw this issue.

@chloestefantsova
Copy link
Contributor Author

@chloestefantsova - did you mean this to be a general 'implement enhanced enums' issue, or just specific to the CFE? I started #47849 but then saw this issue.

I meant this as the CFE specific one, so the two issues are in agreement with each other 🙂

@devoncarew devoncarew mentioned this issue Dec 6, 2021
Closed
23 tasks
@devoncarew devoncarew added this to To do in enhanced-enums via automation Dec 6, 2021
copybara-service bot pushed a commit that referenced this issue Dec 27, 2021
@chloestefantsova
[cfe] Create non-trivial constructor scope for enums
f5e11c2 
Part of #47453

Change-Id: I785c0c26dea8ad9443a531cf372db4e7f3b999bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224954
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 30, 2021
@chloestefantsova
[cfe] Add basic support for enum-specific semantics of constructors
29ceb2f 
Part of: #47453

Change-Id: I1922460a8045db9ffd8bae7bff7ddb4e8c2c0ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225721
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 3, 2022
@chloestefantsova
[cfe] Add initial support for enum fields
ae69916 
Part of #47453

Change-Id: I39c3d29ef31aa51db4f266c7330ac8e47260d749
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225727
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 3, 2022
@chloestefantsova
[cfe] Adjust redirecting initializers of enum constructors
0ee2b0f 
Part of #47453

Change-Id: I46a96c8c6ab4d54186ad612e3c7586cc92781d87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225729
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This was referenced Jan 5, 2022
Closed
Closed
copybara-service bot pushed a commit that referenced this issue Jan 10, 2022
@chloestefantsova
[cfe] Add support for factories and methods in enums
384aeb3 
Part of #47453

Closes #48084

Change-Id: If96b17220df63b5f0089e302322fad2735354d5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226687
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
This was referenced Jan 13, 2022
Closed
Closed
copybara-service bot pushed a commit that referenced this issue Jan 13, 2022
@chloestefantsova
[cfe] Allow mixins in enums
bd04424 
Part of #47453

Change-Id: I04d0a7690b6619ca61f364da756917319e6081b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227541
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 14, 2022
@chloestefantsova
[cfe] Add basic support for intertfaces implemented by enums
eb3d490 
Part of #47453

Closes #48140

Change-Id: I6f45fa869a0cf64ae041e0768a0129a989e6d903
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228161
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 14, 2022
@chloestefantsova
[cfe] Support type arguments on enum types
7cf4cf5 
Part of #47453

Closes #48141

Change-Id: Ibfda7546ba0da91dbd0430f55b878af58a1bb99c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228202
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 17, 2022
@chloestefantsova
[cfe] Support named constructor arguments in enum elements
5261e6e 
Part of #47453

Change-Id: I68e9d822527bce84828924f849468d23794a4feb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228501
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 18, 2022
@chloestefantsova
[cfe] Allow abstract classes to implement and extend Enum
df0f476 
Part of #47453

Change-Id: I6782b4a9f13f95f626f41c311c05ce949649c828
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228562
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 19, 2022
@chloestefantsova
[cfe] Infer missing type arguments on enum elements
a03eb19 
This CL also moves the resolution of the _Enum type before it's
checked for being a correct supertype.

Part of #47453

Change-Id: I80d4197a430b90e4aea785961bfbcbbee588255a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228644
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 20, 2022
@chloestefantsova
[cfe] Report errors on indirect implementation of Enum
def9a76 
Part of #47453

Change-Id: I00fc3ca00713b1181eb0179312d3eb68cfeae334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228648
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 24, 2022
@chloestefantsova
[cfe] Error on type arguments without value arguments in enum elements
0ff6340 
Part of #47453

Change-Id: Icf8b5a58d991c4fb693fd41e9b49dc326269c9fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229153
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 25, 2022
@chloestefantsova
[cfe] Named factories don't prevent synthesized default enum constructor
e0d0ff6 
Closes #48181

Part of #47453

Change-Id: Idac70540cf2d4b566fa88bad1e7feef1aec9e3a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229540
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 27, 2022
@chloestefantsova
[cfe] Make _Enum type pre-created similarly to built-in types
13713c2 
Part of #47453

Change-Id: I046fc14b76513b6b1b3f3606b4c1bd299abca50a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229963
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 31, 2022
@chloestefantsova
[cfe] Report more errors on forbidden enum constructor calls
5f0433a 
This CL also adds support for redirecting enum factories.

Part of #47453

Change-Id: Idd16598316a52ac6122a47f4c12f82ab5750d8f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230661
Auto-Submit: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
@alexmarkov alexmarkov mentioned this issue Feb 10, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Feb 11, 2022
@chloestefantsova
[cfe] Infer constness in enum element initializers
7263b35 
Part of #47453

Closes #48233

Change-Id: Iaa75ccac6622e874da5f6e5feb053fc19a220936
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232382
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 11, 2022
@chloestefantsova
[cfe] Check enum elements against all other members for diplication
0ef68f8 
Part of #47453

Closes #48342

Change-Id: Iea4b147eaed19681e227d84a9afc6a1069b1e3fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232380
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 11, 2022
@chloestefantsova
[cfe] Fix _name field resolution for toString body generation
ab84be0 
Part of #47453

Closes #48303

Change-Id: Ib2934779fc7295c066c1c1580609c933be76b618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232381
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 15, 2022
@chloestefantsova
[cfe] Report errors on declared 'values' member in enums
6c8ad6a 
Part of #47453

Closes #48389
Closes #48387

Change-Id: I8313e3f63122c85c91a9647ddaa53346591d7238
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232841
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 17, 2022
@chloestefantsova
[cfe] Report errors on implementors of 'Enum' declaring 'values'
deba7fe 
Part of #47453

Closes #48388

Change-Id: I87d57407e16916a78864b9ce74b9250afc39958f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233304
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 21, 2022
@chloestefantsova
[cfe] Preserve correct enum elements to avoid cascading errors
53cdbfb 
Part of #47453

Change-Id: Ic79a7667e5eb1b4cf27c1d1628312e4d8c052304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233382
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 10, 2022
@chloestefantsova
[cfe] Perform inference on enum elements as on other fields
c162674 
The type inference on enum elements was performed at the outline
expression building phase, which is later than the inference on the
rest of the members. It prevents some type checks from being performed
correctly, for example, a check for the type of the getter induced by
the element and a declared static setter. This CL moves the inference
on enum elements to the same phase as for the rest of the class and
enum members.

Part of #47453

Change-Id: Iefc5606e6db07df8cd2de101c47d115c2ff8454a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236000
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 16, 2022
@chloestefantsova
[cfe] Report errors on restricted instance members in enums
5bd7d75 
Part of #47453

Change-Id: I2fddd2ad5da82807fef7e9ed1d7a6781fde38600
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237365
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 24, 2022
@chloestefantsova
[cfe] Report errors on restricted members in Enum implementers
050ffd6 
Closes #48577

Part of #47453

Change-Id: I949052f153c2e7b1c818069149c75b977ca8ac95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237580
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 24, 2022
@chloestefantsova
[cfe] Report errors in inherited restricted members in enums
d291c53 
Part of #47453

Change-Id: I5f80c3507a0264c4516d42967b148f4dc3fd08ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237684
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 31, 2022
@chloestefantsova
[cfe] Avoid synthesized locations for reporting conflict errors
d2b0a37 
Part of #47453

Change-Id: I51277f2c548b4632b9b9870b522f19a9e8c77498
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239680
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 31, 2022
@chloestefantsova
[cfe] Report error on immediately declared abstract membrs in enums
27f9b25 
Part of #47453

Change-Id: I376b309e019a1e18444613f14c9e8870c0f10eb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239681
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
@chloestefantsova
Copy link
Contributor Author

This is considered implemented.

enhanced-enums automation moved this from To do to Done Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool)
Projects
enhanced-enums
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @devoncarew