Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for WeakReference, Finalizer and NativeFinalizer #47774

Closed
Tracked by #47772
mraleph opened this issue Nov 25, 2021 · 3 comments
Closed
Tracked by #47772

Add tests for WeakReference, Finalizer and NativeFinalizer #47774

mraleph opened this issue Nov 25, 2021 · 3 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@mraleph
Copy link
Member

mraleph commented Nov 25, 2021

No description provided.

@mraleph mraleph added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Nov 25, 2021
@mraleph
Copy link
Member Author

mraleph commented Nov 25, 2021

Likely we will have to create VM only tests and rely on JS implementation to be correct.

@dcharkes
Copy link
Contributor

@mraleph I have landed tests as part of my CLs, and co19 has also landed tests. Should this issue be closed?

@rileyporter is the JS side covered with tests as well?

@rileyporter
Copy link
Contributor

For the JS side, yes, I think we can close this issue.

We added some minimal tests for the JS API, but we aren't testing the native JS behavior that is underlying the web implementation. The garbage collection behavior for JS is not guaranteed or reliably controlled, so any tests relying on the JS behavior would probably be flaky and not give us much extra coverage. There might be some extra coverage coming from the co19 tests, but I think they ran into the same issues with testing the JS behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

3 participants