Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report analysis_options options implicit-casts or implicit-dynamic as deprecated #47902

Closed
srawlins opened this issue Dec 11, 2021 · 3 comments
Closed

Report analysis_options options implicit-casts or implicit-dynamic as deprecated #47902

srawlins opened this issue Dec 11, 2021 · 3 comments
Assignees
@srawlins
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on strict-analysis-needed Mark issues where strict-raw-types, strict-inference and similar analysis options were helpful type-enhancement A request for a change that isn't a bug

Comments

@srawlins
Copy link
Member

Need to write new (or use existing) infra for reporting uses of implicit-casts: false (replaced by strict-casts: true) and implicit-dynamic: false (replaced by strict-raw-types: true) in analysis_options.yaml.
@srawlins srawlins added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Dec 11, 2021
@srawlins srawlins self-assigned this Dec 11, 2021
@srawlins srawlins mentioned this issue Dec 11, 2021
Closed
@bwilkerson
Copy link
Member

Please add this to OptionsFileValidator. It will be easier to maintain if all the checks are together.

copybara-service bot pushed a commit that referenced this issue Dec 20, 2021
@srawlins
Use new strict-casts option in dart_internal
cadd5cc 
Bug: #47902
Change-Id: Ica869d6884e7ab47c90f893662f759c9e89021de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 20, 2021
@srawlins
telemetry: Use the new strict-casts instead of deprecated no-implicit…
f90b6e0 
…-casts

Bug: #47902
Change-Id: I99919a08d4f051bd3c294fd901a1f1833209d673
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 20, 2021
@srawlins
Add strict-casts to YAML completion
f596d23 
Bug: #47902
Change-Id: Iaabe459d88ed50640d7b28578bbfe3f22cf36c17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225048
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 21, 2021
@srawlins
smith: Use strict-casts instead of no-implicit-casts
bcae980 
These modes are almost identical; one difference which is highlighted
below is that a `dynamic` value used in a spread is considered to be
an implicit cast from dynamic to Iterable.

Bug: #47902
Change-Id: Iabb6881c72e29349c36ce99e29853a8315b6f4dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225044
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@dcharkes
Copy link
Contributor

@srawlins 6a54fdd broke the flutter-analyze bot.

Flutter needs to be migrated.

@srawlins
Copy link
Member Author

Agreed ☹️ will revert.

copybara-service bot pushed a commit that referenced this issue Mar 27, 2022
@srawlins
Revert "analyzer: Mark implicit-casts and implicit-dynamic as depreca…
5050f31 
…ted"

This reverts commit 6a54fdd.

Reason for revert: broke flutter-analyze

Original change's description:
> analyzer: Mark implicit-casts and implicit-dynamic as deprecated
>
> Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
> a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.
>
> Fixes #47902
>
> Change-Id: I293c3c1fd671ac85c12f9c050465b4d77632f241
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224800
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib2e9492716d3ff6da4fa4e1c64fd658451b16d88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239008
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@blendthink blendthink mentioned this issue May 28, 2022
Closed
blendthink added a commit to blendthink/flutter-mobile-lints that referenced this issue Jun 24, 2022
@blendthink
♻️ remove unnecessary 'implicit-dynamic: false'
1dcae86 
#14
dart-lang/sdk#47902
@blendthink blendthink mentioned this issue Sep 7, 2022
Closed
1 task
@srawlins srawlins reopened this Dec 20, 2022
@srawlins srawlins mentioned this issue Jan 4, 2023
Merged
8 tasks
@eernstg eernstg added the strict-analysis-needed Mark issues where strict-raw-types, strict-inference and similar analysis options were helpful label Apr 18, 2023
@modulovalue modulovalue mentioned this issue Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on strict-analysis-needed Mark issues where strict-raw-types, strict-inference and similar analysis options were helpful type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @dcharkes @bwilkerson @eernstg