-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis server crashes after increasing min SDK constraint to 2.15 #47963
Comments
I can reproduce this in a unit test in ResynthesizeAstKeepLinkingTest; the issue here is an implicit call reference ( |
Bug: #47963 Change-Id: Ice412be0ced087f90486e9e1612e3be616ec6d6b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225760 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Fixed by 4b16e02 |
@srawlins The commit you mention has 2.16.0-xx labels, I'm assuming that means it is fixed in Dart 2.16.0. But I still see the issue with Dart 2.16.1. I managed to narrow it down to the code that causes the issue (edit: I see that this is basically what you already mentioned). In this example, uncommenting the class Foo {
/* const */ Foo.bar() : this(const _Dummy());
const Foo(this.foo);
final void Function(bool) foo;
}
class _Dummy {
const _Dummy();
void call(bool x) {}
} Perhaps related, if I add: void fun() {
const x = Foo(_Dummy()); // *
} IntelliJ reports and error on the starred line: "A value of type 'Null' can't be assigned to a parameter of type 'void Function(bool)' in a const constructor. With SDK set to >=2.13, a similar error is reported, but instead of |
Hmm I don't see the commit in 2.16.1. https://github.com/dart-lang/sdk/commits/2.16.1 But I could be wrong. |
After increasing the minimum SDK constraint of our packages to 2.15, the analysis server crashes after a while. Breaking syntax highlighting, code completion, etc. Things worked fine when the constraint was still
>=2.12
in our pubspec.yaml files and>=2.14.0
in pubspec.lock files due to some dependency that required it (but using Flutter 2.8/Dart 2.15).Dart analysis issue
Exception: Missing implementation of visitImplicitCallReferenceImpl
Version information
Details
Exception: Missing implementation of visitImplicitCallReferenceImpl
Debug log
The text was updated successfully, but these errors were encountered: