Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The message for MISSING_ANNOTATION_ON_STRUCT_FIELD could be improved #48256

Closed
bwilkerson opened this issue Jan 30, 2022 · 1 comment
Closed

The message for MISSING_ANNOTATION_ON_STRUCT_FIELD could be improved #48256

bwilkerson opened this issue Jan 30, 2022 · 1 comment
Labels
analyzer-ux area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@bwilkerson
Copy link
Member

The problem message for FfiCode.MISSING_ANNOTATION_ON_STRUCT_FIELD could be improved. In a review with the FFI team, we agreed on the following message: "Fields of type '{0}' in a subclass of '{1}' must have an annotation indicating the native type.".

This might require some reworking of the FfiVerifier in order to make the two argument values available in the scope where the diagnostic is generated.
@bwilkerson bwilkerson added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-ux labels Jan 30, 2022
@srawlins srawlins added the P3 A lower priority bug or feature request label Feb 28, 2022
@CicadaCinema
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/241280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-ux area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @bwilkerson @CicadaCinema