Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is dart affected by Zlib Vulnerability - CVE-2018-25032? #48725

Closed
boldt opened this issue Apr 1, 2022 · 6 comments
Closed

Is dart affected by Zlib Vulnerability - CVE-2018-25032? #48725

boldt opened this issue Apr 1, 2022 · 6 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@boldt
Copy link

boldt commented Apr 1, 2022

Is dart, and thus flutter, affeted by the Zlib Vulnerability - CVE-2018-25032?
@devoncarew devoncarew added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Apr 1, 2022
@devoncarew
Copy link
Member

@a-siva for triage; @khyati82 for awareness

@aam
Copy link
Contributor

aam commented Apr 1, 2022

https://dart-review.googlesource.com/c/sdk/+/239820 rolls dart vm's zlib to 1.2.12

copybara-service bot pushed a commit that referenced this issue Apr 1, 2022
@aam
[zlib] Update dart zlib dependency to get zlib 1.2.12
29f9b20 
Addresses #48725
TEST=ci

Change-Id: I34a8c974c88e6047de01d431f687e187b6d294a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239820
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@boldt
Copy link
Author

boldt commented Apr 4, 2022 •
edited

Looking into the commit 29f9b20, I see you bumped the hash to faff052b6b6edcd6dd548513fe44ac0941427bf0 of zlib_rev. Where do I find zlib_rev with the corresponding hash?

@aam
Copy link
Contributor

aam commented Apr 4, 2022

https://chromium.googlesource.com/chromium/src/third_party/zlib/+/faff052b6b6edcd6dd548513fe44ac0941427bf0

https://github.com/dart-lang/sdk/blob/main/DEPS#L260 is where the dependency is defined for dart sdk.

Was that what you were asking?

@aam aam mentioned this issue Apr 11, 2022
Closed
@a-siva a-siva mentioned this issue Apr 11, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Apr 18, 2022
@aam @whesse
[zlib] Update dart zlib dependency to get zlib 1.2.12
cc81208 
Addresses #48725
TEST=ci

Change-Id: I34a8c974c88e6047de01d431f687e187b6d294a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239820
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@ramkgunturu12
Copy link

How we need to update Zlib in flutter app because it is showing vulnerability in security check

@keithhie keithhie mentioned this issue Jun 23, 2022
Closed
@aam
Copy link
Contributor

aam commented Jun 28, 2022

@ramkgunturu12 wrote

How we need to update Zlib in flutter app because it is showing vulnerability in security check

Fixed version of zlib was rolled into dart starting from 2.17.0-266.5.beta, flutter starting from 2.13.

So as long as you run on recent versions of dart/flutter, you should be fine.

@aam aam closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aam @boldt @devoncarew @ramkgunturu12