Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a "canary" mode in DDC builds #48950

Closed
7 tasks done
nshahan opened this issue May 3, 2022 · 1 comment
Closed
7 tasks done

Add support for a "canary" mode in DDC builds #48950

nshahan opened this issue May 3, 2022 · 1 comment
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler web-infrastructure internal techdebt or infrastructure issues affecting the web team specifically

Comments

@nshahan
Copy link
Contributor

nshahan commented May 3, 2022 •
edited

It would be helpful to have support for a canary mode in DDC. This mode would enable some set of features currently under development. We need some support for this in:

  • local builds and tests
  • test bot configurations
  • benchmark configurations
  • Google internal development builds and tests
  • Google internal global test runs
  • Expression compiler tests
  • Modular test suite
@nshahan nshahan added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-infrastructure internal techdebt or infrastructure issues affecting the web team specifically labels May 3, 2022
@nshahan nshahan self-assigned this May 3, 2022
copybara-service bot pushed a commit that referenced this issue May 10, 2022
@nshahan
[ddc] Add flag to use the new runtime type system
112cba1 
Currently the flag does nothing. Follow up changes will add support
incrementally.

Add a `--canary` flag to DDC that will enable all features in
development to simplify use in tests and benchmarks.

Issue: #48950

Change-Id: I4878c771bdb4f4c6e8b8cd618737009268b02cbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237602
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
copybara-service bot pushed a commit that referenced this issue Jun 14, 2022
@nshahan
[ddc] Add new test and builder configurations
6bcb186 
- Add new versions of exisiting configurations to support the arm64
architecture. The current DDC configurations don't name one but
default to x64. In the future I would like to remove the default
and simply specify (x64|arm64) but I'm not making this change now
because I don't want to break the history in the test database.

- Add new "canary" named test configurations that rely on a
specific builder to pass a build time flag
`--gn-args ddc_canary=true`.

Change-Id: I675899ea2e952e2183b8379b60ddaa67e8b864a5
Issue: #48950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243562
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
@nshahan nshahan added the P2 A bug or feature request we're likely to work on label Nov 18, 2022
@nshahan
Copy link
Contributor Author

nshahan commented Nov 18, 2022

Update: adding a benchmark configuration still in progress https://chrome-internal-review.googlesource.com/c/golem/+/4965259.

@nshahan nshahan closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler web-infrastructure internal techdebt or infrastructure issues affecting the web team specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan