Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/dartdev/test/commands/create_integration_test fails on "create integration web" and "create integration web-simple" #48992

Closed
alexmarkov opened this issue May 10, 2022 · 2 comments
Assignees
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. gardening

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on b0f9470 and 34bca35 which look unrelated to the failures.

The test

pkg/dartdev/test/commands/create_integration_test RuntimeError (expected Pass)

is failing on configurations

unittest-asserts-debug-linux
unittest-asserts-release-mac
unittest-asserts-release-mac-arm64

Log:

--- Command "vm" (took 05:28.000443s):
DART_CONFIGURATION=DebugX64 CHROME_PATH=/b/s/w/ir/cache/builder/sdk/third_party/browsers/chrome/chrome/google-chrome out/DebugX64/dart-sdk/bin/dart --enable_asserts -Dtest_runner.configuration=unittest-asserts-debug-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json /b/s/w/ir/cache/builder/sdk/pkg/dartdev/test/commands/create_integration_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: create integration console�[0m

00:59 �[32m+1�[0m: create integration console-full�[0m

01:36 �[32m+2�[0m: create integration package�[0m

02:13 �[32m+3�[0m: create integration package-simple�[0m

02:50 �[32m+4�[0m: create integration server-shelf�[0m

stdout: Server listening on port 8080


03:33 �[32m+5�[0m: create integration web�[0m

04:31 �[32m+5�[0m�[31m -1�[0m: create integration web �[1m�[31m[E]�[0m�[0m

  Expected: <0>
    Actual: <1>
  

  package:test_api/src/expect/expect.dart 134:31                 fail
  package:test_api/src/expect/expect.dart 129:3                  _expect
  package:test_api/src/expect/expect.dart 46:3                   expect
  pkg/dartdev/test/commands/create_integration_test.dart 149:11  defineCreateTests.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 215:9               Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7               Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 257:7                Invoker._waitForOutstandingCallbacks.<fn>
  

04:31 �[32m+5�[0m�[31m -1�[0m: create integration web-simple�[0m

05:08 �[32m+5�[0m�[31m -2�[0m: create integration web-simple �[1m�[31m[E]�[0m�[0m

  Expected: <0>
    Actual: <1>
  

  package:test_api/src/expect/expect.dart 134:31                 fail
  package:test_api/src/expect/expect.dart 129:3                  _expect
  package:test_api/src/expect/expect.dart 46:3                   expect
  pkg/dartdev/test/commands/create_integration_test.dart 149:11  defineCreateTests.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 215:9               Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7               Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 257:7                Invoker._waitForOutstandingCallbacks.<fn>
  

05:09 �[32m+5�[0m�[31m -2�[0m: create integration console-simple�[0m

05:21 �[32m+6�[0m�[31m -2�[0m: �[31mSome tests failed.�[0m



Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python3 tools/test.py -n unittest-asserts-debug-linux pkg/dartdev/test/commands/create_integration_test

https://dart-ci.appspot.com/log/pkg-linux-debug/unittest-asserts-debug-linux/14273/pkg/dartdev/test/commands/create_integration_test

https://dart-ci.appspot.com/log/pkg-mac-release/unittest-asserts-release-mac/21626/pkg/dartdev/test/commands/create_integration_test

https://dart-ci.appspot.com/log/pkg-mac-release-arm64/unittest-asserts-release-mac-arm64/3381/pkg/dartdev/test/commands/create_integration_test

Could be an intermittent infra problem, but it is not clear from the test output.

/cc @bkonyi

@alexmarkov alexmarkov added gardening area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. labels May 10, 2022
@bkonyi
Copy link
Contributor

bkonyi commented May 11, 2022

Could very well be an infra issue. At the very least, we should be outputting more information.

copybara-service bot pushed a commit that referenced this issue May 11, 2022
We've seen runtime errors due to non-zero exit codes when running this
suite of tests, but it's difficult to tell at which command we've
failed. This adds logging to help narrow down which command is causing
the issues.

Related issue: #48992

Change-Id: Ice0ff2ef87c806d108e907bcac84e5cc09b176f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244366
Reviewed-by: Alexander Markov <alexmarkov@google.com>
@bkonyi bkonyi self-assigned this May 12, 2022
@bkonyi
Copy link
Contributor

bkonyi commented May 12, 2022

This is one of the very few tests that actually hit the network to get webdev from pub. Looks like webdev was broken due to some bad dependency constraints, should be fixed when dart-lang/webdev#1607 is resolved.

@bkonyi bkonyi closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. gardening
Projects
None yet
Development

No branches or pull requests

2 participants