Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] Please cherry pick da18c7c9a7080cc0ccd8455e1df85289b6445174 into the beta branch #49493

Closed
a-siva opened this issue Jul 20, 2022 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request merge-to-beta

Comments

@a-siva
Copy link
Contributor

a-siva commented Jul 20, 2022

Commit(s) to merge

da18c7c

Target

beta

Issue Description

Future produced by async function has wrong type argument

This is a regression that was introduced in the new restructured async implementation.

What is the fix

In order to create a Future for the result of async closure,
closure needs to instantiate a type argument of its result type.
The result type may reference type arguments of enclosing function or
class and scope builder should visit closure's result type
in order to capture receiver or type arguments variable of parent
factory.

https://dart-review.googlesource.com/c/sdk/+/251320

Why cherry-pick

It is a regression

Risk

low

Issue link(s)

#49424

Extra Info

The CL merges cleanly into the beta channel.

@a-siva a-siva added merge-to-beta cherry-pick-review Issue that need cherry pick triage to approve labels Jul 20, 2022
@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jul 20, 2022
@itsjustkevin
Copy link
Contributor

@a-siva is this regression applicable to the stable branch also?

@vsmenon @athomas @sigmundch could you give votes on this cherry-pick?

@vsmenon
Copy link
Member

vsmenon commented Jul 21, 2022

lgtm

@sigmundch
Copy link
Member

lgtm as well

@a-siva
Copy link
Contributor Author

a-siva commented Jul 21, 2022

@a-siva is this regression applicable to the stable branch also?

No.

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Jul 21, 2022
@whesse
Copy link
Contributor

whesse commented Jul 26, 2022

This fix is cherry-picked in 2.18.0-271.4.beta.

@whesse whesse closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request merge-to-beta
Projects
None yet
Development

No branches or pull requests

7 participants