Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect definition in the section 7(Classes) of the language specification #497

Closed
DartBot opened this issue Nov 17, 2011 · 3 comments
Closed
Assignees
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).

Comments

@DartBot
Copy link

DartBot commented Nov 17, 2011

This issue was originally filed by ms...@unipro.ru


Specification defines in section 7:

classMemberDefinition:
  declaration ';' |
  methodSignature functionBody
;
declaration:
  constantConstructorSignature (redirection | initializers)? |
  constructorSignature (redirection | initializers)? ...

According to this a constructor with initializers can't have a body.

Also there are 'functionSignature redirection' and 'functionSignature initializers'. It seems that functionSignature should be replaced with constructorSignature.

@DartBot
Copy link
Author

DartBot commented Nov 17, 2011

This comment was originally written by drfibonacci@google.com


Added Area-Language, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Nov 21, 2011

This comment was originally written by ms...@unipro.ru


In 'MethodSignature' definition:
'static functionSignature' should be 'static? functionSignature'.
'getterSignature' and 'setterSignature' miss 'static?' prefix.

@gbracha
Copy link
Contributor

gbracha commented Dec 15, 2011

Here's the latest from the 0.07 draft:

methodSignature:
      factoryConstructorSignature
    | static? functionSignature
    | getterSignature
    | setterSignature
    | operatorSignature
    | constructorSignature initializers?
    ;

declaration:
      constantConstructorSignature (redirection | initializers)?
    | constructorSignature (redirection | initializers)?
    | abstract getterSignature
    | abstract setterSignature
    | abstract operatorSignature
    | abstract functionSignature
    | static final type? staticFinalDeclarationList
    | static? initializedVariableDeclaration

Note that getterSignature and setterSignature already incorporate the optional static prefix so that comment was invalid.


Set owner to @gbracha.
Added Done label.

@DartBot DartBot added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Dec 15, 2011
copybara-service bot pushed a commit that referenced this issue Sep 29, 2022
dartdoc (https://github.com/dart-lang/dartdoc/compare/62bc150..866338f):
  866338f1  2022-09-29  Sam Rawlins  Bump to 6.1.2 (#3198)

html (https://github.com/dart-lang/html/compare/8243e96..faafebf):
  faafebf  2022-09-29  Devon Carew  Merge pull request #188 from dart-lang/update_readme
  d27b898  2022-09-29  Devon Carew  Merge pull request #189 from dart-lang/update_ci
  5a0be75  2022-09-29  Devon Carew  update to our current CI best practices
  4185afd  2022-09-29  Devon Carew  add markdown badges to the readme

intl (https://github.com/dart-lang/intl/compare/5464b3b..7639a15):
  7639a15  2022-09-27  Nate Bosch  Simplify the IntlStream class (#494)
  a4b44a9  2022-09-27  Lasse R.H. Nielsen  Cleanup of `var this.`, dynamic parameters, and more (#497)

mime (https://github.com/dart-lang/mime/compare/0a75a41..bf041aa):
  bf041aa  2022-09-26  Devon Carew  update action versions; add dependabot config (#69)

usage (https://github.com/dart-lang/usage/compare/e287a72..9a98c89):
  9a98c89  2022-09-29  Devon Carew  whitespace change to the LICENSE file (#182)
  cf284c7  2022-09-29  Kevin Moore  analysis options and lint cleanup (#183)

Change-Id: I0a6bd0de7bc75cd84b20e1de6f0463544ac68a70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262020
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).
Projects
None yet
Development

No branches or pull requests

3 participants