Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [ddc] Fix bug in FutureOr type normalization #50121

Closed
nshahan opened this issue Oct 4, 2022 · 1 comment
Closed

Failures on [ddc] Fix bug in FutureOr type normalization #50121

nshahan opened this issue Oct 4, 2022 · 1 comment
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@nshahan
Copy link
Contributor

nshahan commented Oct 4, 2022

There are new test failures on [ddc] Fix bug in FutureOr type normalization.

The tests

language/nnbd/normalization/future_or_never_normalization_test RuntimeError (expected Pass)

are failing on configurations

dartkp-weak-asserts-linux-release-x64
dartkp-weak-asserts-mac-release-arm64

I discovered some normalization bugs in DDC and dart2js so I added more tests for specific constructions of FutureOr<Never> in various forms of nullability and legacy types. The new tests are intended to check if null is considered to be the type in an is test whereas previously the tests only checked that the normalization was consistent between compile time and runtime implementations. I didn't see any failures when I submitted but these bots ran on post submit and reported the failures.

cc @alexmarkov
@nshahan nshahan added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Oct 4, 2022
@a-siva
Copy link
Contributor

a-siva commented Oct 4, 2022

/cc @alexmarkov

@alexmarkov alexmarkov self-assigned this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nshahan @a-siva @alexmarkov