Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[riscv] co19/LibTest/core/List/List_all_t03 Timeout #50408

Closed
dcharkes opened this issue Nov 8, 2022 · 1 comment
Closed

[riscv] co19/LibTest/core/List/List_all_t03 Timeout #50408

dcharkes opened this issue Nov 8, 2022 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Nov 8, 2022

There are new test failures on [vm, compiler] Don't clobber preserved register in assembler test....Issue 50384. Support RedirectingConstructorInvocation for NOT_ENOUGH_POSITIONAL_ARGUMENTS..

The tests

co19/LibTest/core/List/List_all_t03 Timeout (expected Pass)

are failing on configurations

dartk-weak-asserts-linux-debug-simriscv64

cc @rmacnak-google I don't see any risc-v related commits in that range. Any chance the test was on the verge of timing out before?
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening labels Nov 8, 2022
copybara-service bot pushed a commit that referenced this issue Nov 11, 2022
@rmacnak-google
[vm, compiler] Remove quadratic time spent verifying handle lifetime.
715866a 
Instead of checking whether a handle is a zone handle rather than a scoped handle by iterating the zone handle blocks, reserve an extra slot in debug mode to record the handle's lifetime.

TEST=ci
Bug: #50408
Change-Id: I121c76d02b03e5d2141450077bc6e9da3cb60a5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268801
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@a-siva
Copy link
Contributor

a-siva commented Nov 14, 2022

Closing based on CL above.

@a-siva a-siva closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcharkes @a-siva