Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm/cc/IsolateReload_NotTypedefToTypedef is flaky on vm-precomp-ffi-qemu-linux-release-riscv64 #50521

Open
derekxu16 opened this issue Nov 21, 2022 · 1 comment
Open

vm/cc/IsolateReload_NotTypedefToTypedef is flaky on vm-precomp-ffi-qemu-linux-release-riscv64 #50521

derekxu16 opened this issue Nov 21, 2022 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening

Comments

@derekxu16
Copy link
Member

https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-precomp-ffi-qemu-linux-release-riscv64/479/overview
@derekxu16 derekxu16 added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening labels Nov 21, 2022
@mkustermann
Copy link
Member

This happened again today. The test has been marked a Fail in status files for long time, but the status file markers are ignored. The results database shows it as failing in all configs - apparently approved failures.

It may be flakying between two failure states (e.g. timeout & fail) on risc-v.

This particular test is testing an error that isn't an error anymore, so I think the test has to be updated.

copybara-service bot pushed a commit that referenced this issue Feb 20, 2023
@mkustermann
[gardening] Fix vm/cc/IsolateReload_{TypedefToNotTypeDef,NotTypedefTo…
15ecb9b 
…TypeDef} tests

With introduction to Dart 2.0 and Kernel as intermediate format, the VM
consumes kernel. The kernel is produced by CFE which lowers named
function type definitions to function types.

We therefore no longer have name classes between typedefs and classes
and the corresponding vm/cc/IsolateReload_* can be updated to no longer
expect an error.

Issue #50521
Issue #32190

TEST=Fixes vm/cc/IsolateReload_*Typedef* tests

Change-Id: Ic0697c5de03ef28e6cca104f5fbcb214e99d3fd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284182
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derekxu16 @mkustermann