[analysis_server] Extension has kind CLASS in search.getElementDeclarations

[sstasi95]

Hi,

The request search.getElementDeclarations returns kind CLASS for Extensions, but I think it should return kind EXTENSION.
Code to reproduce the issue (using package:analysis_server_lib):

import 'dart:async';
import 'dart:io';

import 'package:analysis_server_lib/analysis_server_lib.dart';
import 'package:path/path.dart' as path;

class ServerHelper {
  static Future<ServerHelper> create() async {
    return ServerHelper(await AnalysisServer.create());
  }

  final AnalysisServer server;
  Directory tempDir;
  Map<String, List<AnalysisError>> errors = {};

  ServerHelper(this.server) : tempDir = Directory.systemTemp.createTempSync('tests');

  Future init() {
    server.analysis.onErrors.listen((AnalysisErrors e) {
      if (e.errors.isEmpty) {
        errors.remove(e.file);
      } else {
        errors[e.file] = e.errors;
      }
    });

    server.server.setSubscriptions(['STATUS']);
    return server.analysis.setAnalysisRoots([tempDir.path], []);
  }

  Stream get onAnalysisFinished {
    return server.server.onStatus.where((ServerStatus status) {
      return status.analysis != null && status.analysis!.isAnalyzing == false;
    });
  }

  Future<String> createFile(String filePath, String text) {
    String fullPath = path.join(tempDir.path, filePath);
    return server.analysis.updateContent(
      {fullPath: new AddContentOverlay(text)},
    ).then((_) => fullPath);
  }

  void dispose() {
    server.dispose();
    tempDir.deleteSync(recursive: true);
  }
}

Future<void> main() async {
  final helper = await ServerHelper.create();
  await helper.init();
  String main = await helper.createFile('int_ext.dart', 'extension IntExt on int {}');

  final member = await helper.server.search.getElementDeclarations(file: main);
  for (final res in member.declarations) {
    print('${res.name} - ${res.kind}'); // prints IntExt - CLASS, but it should print IntExt - EXTENSION
  }

  helper.dispose();
}

• analysis_server_lib version: 0.2.3
• dart --version: Dart SDK version: 2.18.4 (stable) (Tue Nov 1 15:15:07 2022 +0000) on "macos_arm64"

Thanks,

Simone

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/274085