Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vm] Support building Android target on Mac M1 arm64 #51242

Open
dcharkes opened this issue Feb 3, 2023 · 0 comments
Open

[vm] Support building Android target on Mac M1 arm64 #51242

dcharkes opened this issue Feb 3, 2023 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Feb 3, 2023 

dacoharkes-macbookpro2:sdk dacoharkes$ tools/build.py -aarm64c --os=android ffi_test_functions runtime
ERROR Unresolved dependencies.
//:runtime(//build/toolchain/android:clang_arm64)
  needs //runtime/bin:analyze_snapshot(//build/toolchain/mac:clang_arm64)

Command failed: /Users/dacoharkes/dart-sdk/sdk/buildtools/gn gen xcodebuild/DebugAndroidARM64C --ide=xcode --args=target_os="android" host_cpu="arm64" target_cpu="arm64" dart_target_arch="arm64" dart_use_compressed_pointers=true dart_use_crashpad=false dart_snapshot_kind="app-jit" bssl_use_clang_integrated_as=true dart_use_tcmalloc=false dart_use_mallinfo2=false is_debug=true is_release=false is_product=false dart_debug=true dart_runtime_mode="develop" exclude_kernel_service=false is_clang=true dart_vm_code_coverage=false is_asan=false is_lsan=false is_msan=false is_tsan=false is_ubsan=false is_qemu=false dart_platform_sdk=false dart_stripped_binary="exe.stripped/dart" dart_precompiled_runtime_stripped_binary="exe.stripped/dart_precompiled_runtime_product" gen_snapshot_stripped_binary="exe.stripped/gen_snapshot_product" analyze_snapshot_binary="exe.stripped/analyze_snapshot" use_goma=true goma_dir="/Users/dacoharkes/depot_tools/.cipd_bin" verify_sdk_hash=true
using /var/folders/2y/mngq9h194yzglt4kzttzfq6800klzg/T/goma_dacoharkes as tmpdir
# login as dacoharkes@google.com
override GOMA_PROVIDE_INFO=true
override GOMA_SEND_USER_INFO=true
override GOMA_COMPILER_PROXY_ENABLE_CRASH_DUMP=true
override GOMACTL_USE_PROXY=true
Enable http_proxy
override GOMA_SERVER_HOST=127.0.0.1
override GOMA_SERVER_PORT=19080
override GOMA_USE_SSL=false
GOMA version f24b71a9d773a5c6ab675af7a48662d06bed57f9@1675309961

server: goma.chromium.org:443 (via http_proxy)
goma is already running.

buildtools/ninja/ninja -C xcodebuild/DebugAndroidARM64C -j1000 -l64 ffi_test_functions runtime
ninja: Entering directory `xcodebuild/DebugAndroidARM64C'
ninja: error: loading 'build.ninja': No such file or directory
buildtools/ninja/ninja -C xcodebuild/DebugAndroidARM64C -j1000 -l64 ffi_test_functions runtime done.

I believe this used to work before:
@dcharkes dcharkes added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Feb 3, 2023
copybara-service bot pushed a commit that referenced this issue Feb 6, 2023
@rmacnak-google
[build] Make build_analyze_snapshot consistent between the host and…
8818259 
… target toolchains.

Bug: #51242
Change-Id: I7a0ad1f0bc94c4593412945e4887f9045693fd40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280782
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 7, 2023
@whesse
Revert "[build] Make build_analyze_snapshot consistent between the …
b5302e5 
…host and target toolchains."

This reverts commit 8818259.

Reason for revert: The Fuchsia build of Flutter engine is broken by this change, since it uses the analyze_snapshot target.

Original change's description:
> [build] Make `build_analyze_snapshot` consistent between the host and target toolchains.
>
> Bug: #51242
> Change-Id: I7a0ad1f0bc94c4593412945e4887f9045693fd40
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280782
> Reviewed-by: Daco Harkes <dacoharkes@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,dacoharkes@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I3f069274fdef9366fea347ae5f452d2eb2267f70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #51242
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281423
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Auto-Submit: William Hesse <whesse@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 7, 2023
@rmacnak-google
Reland "[build] Make build_analyze_snapshot consistent between the …
e8b6c8a 
…host and target toolchains."

Also create this target for Fuchsia, which like Linux and Android uses ELF.

Bug: #51242
Change-Id: I8e991d361b5defaa52b62a78d515a7639a6dfba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281460
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcharkes