Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm/ffi] Native Assets infer_native_assets_yaml tests failing in AppJit #51265

Closed
dcharkes opened this issue Feb 6, 2023 · 1 comment
Closed
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-ffi

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Feb 6, 2023

Tree is open (appjit switched to null safety)

The tests

ffi/native_assets/infer_native_assets_yaml_dart_kernel_snapshot_test
ffi/native_assets/infer_native_assets_yaml_isolate_spawnuri_2_test
ffi/native_assets/infer_native_assets_yaml_isolate_spawnuri_3_test
ffi/native_assets/infer_native_assets_yaml_isolate_spawnuri_test
ffi/native_assets/infer_native_assets_yaml_process_run_test

are failing on configurations

vm-appjit-linux-debug-x64
vm-appjit-linux-release-x64

Pass -> RuntimeError (expected Pass)

logs

PathNotFoundException: Cannot open file, path = '/b/s/w/ir/cache/builder/sdk/out/DebugX64/generated_compilations/vm-appjit-linux-debug-x64/tests_ffi_native_assets_infer_native_assets_yaml_isolate_spawnuri_3_test/infer_native_assets_yaml_isolate_spawnuri_3_helper.dart' (OS Error: No such file or directory, errno = 2)
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-ffi labels Feb 6, 2023
@dcharkes
Copy link
Contributor Author

dcharkes commented Feb 6, 2023

These test weren't run in legacy mode, so it should be new -> RuntimeError.

These tests invoke the VM manually, and require the source files next to it, so running the test again as an appjit test from a different folder doesn't work. These tests should be skipped on appjit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-ffi
Projects
None yet
Development

No branches or pull requests

1 participant