[lint] prefer_final_locals quick-fix

[Punt13140]

Hi,

Since a few days, my IDE (IntelliJ) does not provide a quick-fix (which is just adding the final keyword) for prefer_final_locals rule.

I've tried with Visual Code, and I'm having the same problem.

[srawlins]

Thanks for filing an issue, can you provide a small reproduction of code for which you wish to have the quick fix, but it isn't offered? Thanks!

[Punt13140]

Hi @srawlins,

...everywhere ?

It was working fine, I've been adding final everywhere it was recommended thanks to this quick-fix.
And now I only have the suggestion.

example:

  @override
  Widget build(BuildContext context) {

    List<Widget> modalTiles = [];
    Job job = state.lstJobs!.elementAt(index);
    Size screenSize = MediaQuery.of(context).size;-
    MyColors myColors = Theme.of(context).extension<MyColors>()!;
    //...

[srawlins]

Thanks for the bug report and the repro!

[scheglov]

Do you expect to keep type annotations, but append final?
I.e. convert

void f() {
  int v = 0;
  print(v);
}

into

void f() {
  final int v = 0;
  print(v);
}

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/290261

[Punt13140]

Hi ,

I was on another project (not Dart/Flutter related) so I did not had the time to check if it was fix.

But right now, the quick-fix is not working @scheglov.

Am I suppose to not keep type annotations ?
IMO it is much more readable to keep the type

[srawlins]

@Punt13140 if you are not using the latest Dart/Flutter on the beta or master channel, you won't have this fix yet.