Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer missing error with mixin applications extending a base class #51808

Closed
leafpetersen opened this issue Mar 21, 2023 · 0 comments
Closed

Analyzer missing error with mixin applications extending a base class #51808

leafpetersen opened this issue Mar 21, 2023 · 0 comments
Assignees
@kallentu
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart 3 beta 3

Comments

@leafpetersen
Copy link
Member

Subtypes of a base class must be marked base. The analyzer currently issues no error for this when the subtype is introduced via a mixin application class:

base class BaseClass {}
mixin _MixinOnbject {}
// This should be an error
class SimpleExtendApplication = BaseClass with _MixinOnObject;

This is causing failures in new tests here:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8785990437625762449/+/u/test_results/new_test_failures__logs_

cc @kallentu
@leafpetersen leafpetersen added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Mar 21, 2023
@leafpetersen leafpetersen added this to the Dart 3 beta 3 milestone Mar 21, 2023
@kallentu kallentu self-assigned this Mar 21, 2023
@scheglov scheglov added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Mar 21, 2023
copybara-service bot pushed a commit that referenced this issue Mar 22, 2023
@kallentu
[analyzer] Report base/final subtype restriction error on mixin appli…
37c7f05 
…cations (class type aliases)

Bug: #51808
Change-Id: Ice44cce0ce2793fe578c327bb163e27533657fce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290343
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 22, 2023
@kallentu
[tests] Update tests where analyzer mixin applications were failing.
c7cee7f 
Bug: #51808
Change-Id: I0c3951ab28f96cf1794e0ac1088c975c11935bf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290660
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kallentu kallentu

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart 3 beta 3
Development

No branches or pull requests
3 participants
@scheglov @leafpetersen @kallentu