Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on [VM] Add token position to type argument AssertAssignable call #52737

Closed
dcharkes opened this issue Jun 20, 2023 · 0 comments
Closed
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Jun 20, 2023

There are new test failures on [VM] Add token position to type argument AssertAssignable call.

The tests

vm/dart_2/checked_parameter_assert_assignable_stacktrace_test RuntimeError (expected Pass)

are failing on configurations

dartk-linux-debug-x64
dartk-linux-release-x64
dartkp-linux-debug-x64
dartkp-linux-release-x64

log

Expected line 1 to be `^#0      B.takesA \(.*/checked_parameter_assert_assignable_stacktrace_test.dart:14(:27)?\)$` but was `#0      B.takesA (file:///b/s/w/ir/runtime/tests/vm/dart_2/checked_parameter_assert_assignable_stacktrace_test.dart:16:27)`

It seems that the dart_2 copy of this test is expecting the wrong line number.

Fix in: https://dart-review.googlesource.com/c/sdk/+/309901

@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

1 participant