Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveNonNullAssertion fix removes necessary whitespace afterwards #52913

Closed
oprypin opened this issue Jul 12, 2023 · 0 comments
Closed

RemoveNonNullAssertion fix removes necessary whitespace afterwards #52913

oprypin opened this issue Jul 12, 2023 · 0 comments
Assignees
Labels
analyzer-quick-fix area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@oprypin
Copy link
Contributor

oprypin commented Jul 12, 2023

Example code before:

SubFoo f(Foo foo) {
  return foo! as SubFoo;
}

Example code after the fixer:

SubFoo f(Foo foo) {
  return fooas SubFoo;
}

Relevant imlpementation

await builder.addDartFileEdit(file, (builder) {
builder.addDeletion(range.startStart(bangToken, bangToken.next!));
});

@mraleph mraleph added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jul 13, 2023
@bwilkerson bwilkerson added analyzer-quick-fix P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed analyzer-bulk-fix labels Jul 13, 2023
@pq pq self-assigned this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-quick-fix area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

4 participants