Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gardening] https_client_certificate_test failing in TSAN #52917

Open
dcharkes opened this issue Jul 12, 2023 · 0 comments
Open

[gardening] https_client_certificate_test failing in TSAN #52917

dcharkes opened this issue Jul 12, 2023 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening

Comments

@dcharkes
Copy link
Contributor

The tests

standalone/io/https_client_certificate_test RuntimeError (expected Pass)

are failing on configurations

vm-aot-tsan-linux-release-x64

It's flaking between timeout and runtime error
image

runtime error:

--- Command "vm" (took 269ms):
DART_CONFIGURATION=ReleaseTSANX64 TEST_COMPILATION_DIR=/b/s/w/ir/out/ReleaseTSANX64/generated_compilations/vm-aot-tsan-linux-release-x64/tests_standalone_io_https_client_certificate_test out/ReleaseTSANX64/dart_precompiled_runtime --sound-null-safety -Dtest_runner.configuration=vm-aot-tsan-linux-release-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/out/ReleaseTSANX64/generated_compilations/vm-aot-tsan-linux-release-x64/tests_standalone_io_https_client_certificate_test/out.aotsnapshot

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
PathNotFoundException: Cannot open file, path = '/b/s/w/ir/out/ReleaseTSANX64/generated_compilations/vm-aot-tsan-linux-release-x64/tests_standalone_io_https_client_certificate_test/certificates/client_authority.pem' (OS Error: No such file or directory, errno = 2)
#0      _File.throwIfError (dart:io/file_impl.dart:675)
#1      _File.openSync (dart:io/file_impl.dart:490)
#2      _File.readAsBytesSync (dart:io/file_impl.dart:574)
#3      _SecurityContext.setTrustedCertificates (dart:io-patch/secure_socket_patch.dart:243)
#4      serverContext (file:///b/s/w/ir/tests/standalone/io/https_client_certificate_test.dart:21)
#5      main (file:///b/s/w/ir/tests/standalone/io/https_client_certificate_test.dart)
#6      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:296)
#7      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189)

--- Re-run this test:
python3 tools/test.py -n vm-aot-tsan-linux-release-x64 standalone/io/https_client_certificate_test

https://dart-ci.appspot.com/log/vm-aot-tsan-linux-release-x64/vm-aot-tsan-linux-release-x64/148/standalone/io/https_client_certificate_test

It tries to find a file relative to the script path Platform.script.resolve(path) which is the generated compilations folder.

I believe some // OtherResources= might be missing after 9a5de8e.
@dcharkes dcharkes added gardening area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jul 12, 2023
copybara-service bot pushed a commit that referenced this issue Jul 12, 2023
@dcharkes
[gardening] Declare resources in test
4333288 
And give test more time in tsan.

Bug: #52917
Change-Id: I1342612470d63233b265dc9063b0335ec8bef760
Cq-Include-Trybots: luci.dart.try:vm-tsan-linux-release-x64-try,vm-aot-tsan-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313383
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
osa1 pushed a commit to osa1/sdk that referenced this issue Jul 17, 2023
@dcharkes @osa1
[gardening] Declare resources in test
8140596 
And give test more time in tsan.

Bug: dart-lang#52917
Change-Id: I1342612470d63233b265dc9063b0335ec8bef760
Cq-Include-Trybots: luci.dart.try:vm-tsan-linux-release-x64-try,vm-aot-tsan-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313383
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcharkes