Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk_version_since does not work with dev SDK versions #53142

Closed
mraleph opened this issue Aug 7, 2023 · 2 comments
Closed

sdk_version_since does not work with dev SDK versions #53142

mraleph opened this issue Aug 7, 2023 · 2 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@mraleph
Copy link
Member

mraleph commented Aug 7, 2023

I am developing a package against unreleased SDK 3.1. In the pubspec.yaml I have

environment:
  sdk: ">=3.1.0-348.0.dev <4.0.0"

However analyzer reports:

$ dart analyze
Analyzing native_synchronization...    2.7s

warning • lib/mailbox.dart:108:38 • This API is available since SDK 3.1.0, but constraints '>=3.1.0-348.0.dev <4.0.0' don't guarantee it. Try updating the SDK constraints. • sdk_version_since

This makes it hard to develop packages against not yet released packages.
@mraleph mraleph added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Aug 7, 2023
@mraleph mraleph changed the title sdk_version_since and dev SDK versions sdk_version_since does not work with dev SDK versions Aug 7, 2023
@scheglov scheglov self-assigned this Aug 8, 2023
@scheglov scheglov added the P3 A lower priority bug or feature request label Aug 8, 2023
@scheglov
Copy link
Contributor

scheglov commented Aug 8, 2023

https://dart-review.googlesource.com/c/sdk/+/319302

copybara-service bot pushed a commit that referenced this issue Aug 9, 2023
@scheglov
Issue 53142. Ignore pre-release field when reporting sdk_version_since.
3564f5c 
Bug: #53142
Change-Id: Ifeff83ef56cd560a850e012bcabfebf63c391353
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov scheglov closed this as completed Aug 9, 2023
@mraleph
Copy link
Member Author

mraleph commented Aug 10, 2023

Thanks!

harlanx added a commit to harlanx/mkv_profile that referenced this issue Aug 18, 2023
@harlanx
fix: ignore sdk_version_since
d377f47 
dart-lang/sdk#53142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mraleph @scheglov