Skip to content

[stable] [CP] Please cherry pick fix for "Superslow access to variables" #53541

@a-siva

Description

@a-siva

Commit(s) to merge

8a85dac

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/326242

Issue Description

Please see flutter/flutter#133195
Users are running into super slow cycles while debugging their Flutter apps

What is the fix

Avoid searching static functions in the imported libraries, Searching in the imported libraries could be very slow as they can be huge (e.g. the whole Flutter framework)

References to members are fully resolved in kernel. So, when
looking for a static function in the library scope, there is no need to
search in the imported libraries.

Why cherry-pick

Flutter developers are running into this issue while debugging their apps and is hurting their productivity

Risk

low

Issue link(s)

flutter/flutter#133195

Extra Info

No response

Metadata

Metadata

Labels

area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.cherry-pick-approvedLabel for approved cherrypick requestcherry-pick-mergedCherry-pick has been merged to the stable or beta branch.cherry-pick-reviewIssue that need cherry pick triage to approvemerge-to-stable

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions