[stable] [CP] Please cherry pick fix for "Superslow access to variables" #53541
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-merged
Cherry-pick has been merged to the stable or beta branch.
cherry-pick-review
Issue that need cherry pick triage to approve
merge-to-stable
Comments
a-siva
added
the
cherry-pick-review
a-siva
added
the
area-vm
a-siva
changed the title
|
//cc @alexmarkov |
2 tasks
|
@jakemac53 could you take a look at this cherry-pick? |
|
Well, this should have gone to @dcharkes sorry @jakemac53! |
|
lgtm! |
itsjustkevin
added
merge-to-stable
cherry-pick-approved
copybara-service bot
pushed a commit
that referenced
this issue
Sep 26, 2023
…ed libraries References to members are fully resolved in kernel. So, when looking for a static function in the library scope, there is no need to search in the imported libraries. Searching in the imported libraries could be very slow as they can be huge (e.g. the whole Flutter framework). TEST=manually verified repro from flutter/flutter#133195 Fixes flutter/flutter#133195 Cherry-pick-request: #53541 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/323201 Change-Id: Ib84478cebf761ef574356e8e63bd3e9b5ba1507d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326242 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
itsjustkevin
added
the
cherry-pick-merged
|
I downgraded from Flutter 3.14 Master with this fix to 3.13.6 Stable to debug and create production builds for API level 33 and this is now working fine. This was not just super-slow access to variables. I could NOT build at API level 33 due to SCUDO memory issues as it would always fail. Much appreciated for getting this done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
8a85dac
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/326242
Issue Description
Please see flutter/flutter#133195
Users are running into super slow cycles while debugging their Flutter apps
What is the fix
Avoid searching static functions in the imported libraries, Searching in the imported libraries could be very slow as they can be huge (e.g. the whole Flutter framework)
References to members are fully resolved in kernel. So, when
looking for a static function in the library scope, there is no need to
search in the imported libraries.
Why cherry-pick
Flutter developers are running into this issue while debugging their apps and is hurting their productivity
Risk
low
Issue link(s)
flutter/flutter#133195
Extra Info
No response
The text was updated successfully, but these errors were encountered: