Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v21 - issue with navigator object #53784

Closed
bricss opened this issue Oct 17, 2023 · 9 comments
Closed

Node v21 - issue with navigator object #53784

bricss opened this issue Oct 17, 2023 · 9 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@bricss
Copy link

bricss commented Oct 17, 2023

Runtime goes kaboom 💥 in Node v21 with following error:

TypeError: Cannot read properties of undefined (reading 'indexOf')

All the details can be found -> here
@lrhn lrhn added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Oct 17, 2023
This was referenced Oct 18, 2023
Closed
Closed
@sigmundch
Copy link
Member

@rakudrama note an external contribution in https://dart-review.googlesource.com/c/sdk/+/330987 is available for review.

@amoritan amoritan mentioned this issue Oct 18, 2023
Merged
@nex3 nex3 mentioned this issue Oct 18, 2023
Closed
@nex3
Copy link
Member

nex3 commented Oct 18, 2023

Dart Sass is getting a ton of issues about this, and there's a lot of activity on StackOverflow as well. Please prioritize this fix.

@sigmundch sigmundch added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Oct 18, 2023
@8824PPZ 8824PPZ mentioned this issue Oct 19, 2023
Closed
@ntkme
Copy link
Contributor

ntkme commented Oct 19, 2023

Now the fix has landed in main. It needs to be backported to stable (& beta) branch, then we can cut a new dart-sass release. Can someone from dart team help us with the backporting?

This was referenced Oct 19, 2023
Closed
Closed
@Enet4 Enet4 mentioned this issue Oct 19, 2023
Merged
@sigmundch
Copy link
Member

Thank you @ntkme so much for the PR. We'll get the cherry-pick process started.

@rakudrama - let me know if you are already starting the cherry-pick or if you'd like me to help doing so.

@sigmundch sigmundch mentioned this issue Oct 19, 2023
Closed
@sigmundch
Copy link
Member

update - cherry pick request is in progress: #53810

HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
cf432ff 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Formatting
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
ac40b9d 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Formatting
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
9a8e2b3 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Formatting
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
3dd453c 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Formatting
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
5f89884 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Remove test-files dir
 - Fix QuickPreview unblurred buttons in Linux
 - Formatting
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
3a10699 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Remove test-files dir
 - Fix QuickPreview unblurred buttons in Linux
 - Formatting
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
8c9e861 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Remove test-files dir
 - Fix QuickPreview unblurred buttons in Linux
 - Formatting
@HeavenVolkoff HeavenVolkoff mentioned this issue Oct 21, 2023
Merged
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 21, 2023
@HeavenVolkoff
Dependencies overhaul
c3382c0 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Remove test-files dir
 - Fix QuickPreview unblurred buttons in Linux
 - Formatting
ext pushed a commit to html-validate/html-validate that referenced this issue Oct 21, 2023
build: downgrade to node 20 until dart-lang/sdk#53784 is fixed
6b22a56 
dart-lang/sdk#53784
sass/dart-sass#2123
HeavenVolkoff added a commit to spacedriveapp/spacedrive that referenced this issue Oct 22, 2023
@HeavenVolkoff
Dependencies overhaul
8ae5246 
 - Update dependencies for all projects (except Mobile-only deps)
 - Remove unused dependencies from all projects (except Mobile-only deps)
 - Fix Storybook failing to import sd/ui style
 - Add Node 21 as not supported due to sass-loader not working on it yet (dart-lang/sdk#53784)
 - Add work-around for new rook version requiring webpack specific global property
 - Fix landing dev not working due to missing default env value on dev
 - Fix some incorrect uses of phosphor-icons non server side icons on server components on landing
 - Fix some incorrect uses of phosphor-icons server side icon on client components on landing
 - Fix landing fail to build on dev due to always required a Github Token to get the latest release
 - Fix new Next.js version not suporting Response.redirect due to immutable Headers
 - Add Gitlab as social link for teams page
 - Update Vítor's team photo
 - Add Vítor's twitter link
 - Fix some warning due to missing useEffect dependencies
 - Remove test-files dir
 - Fix QuickPreview unblurred buttons in Linux
 - Formatting
noraj added a commit to noraj/rawsec-cybersecurity-inventory that referenced this issue Oct 22, 2023
@noraj
fix ci
842dc52 
sass currently broken for node 21
dart-lang/sdk#53784
@USA-RedDragon USA-RedDragon mentioned this issue Oct 22, 2023
Merged
1 task
This was referenced Oct 22, 2023
Merged
Merged
Skyost added a commit to Skyost/Agregation that referenced this issue Oct 23, 2023
@Skyost
Changement temporaire de la version de Node.
bf84428 
En attendant dart-lang/sdk#53784.
Skyost added a commit to Skyost/Agregation that referenced this issue Oct 23, 2023
@Skyost
Changement temporaire de la version de Node.
c2bd890 
En attendant dart-lang/sdk#53784.
Skyost added a commit to Skyost/MesCoursDeMaths that referenced this issue Oct 23, 2023
@Skyost
Changement temporaire de la version de Node.
d62a327 
En attendant dart-lang/sdk#53784.
@euaaaio euaaaio mentioned this issue Oct 23, 2023
Closed
@bricss
Copy link
Author

bricss commented Oct 24, 2023

For those who can't wait for fix 🩹 check on how to disable navigator in runtime -> here 📔

@ntkme
Copy link
Contributor

ntkme commented Oct 24, 2023 •
edited
Loading

Node.js v21.1.0 just got released and it added the missing navigator.userAgent, which fixes the dart compatibility issue with Node.js v21.0.0.

@nex3 Still, we should cut a release for dart-sass as soon as dart 3.1.5 is out to reduce the noises.

@ntkme
Copy link
Contributor

ntkme commented Oct 25, 2023

Dart 3.1.5 is out. cc @nex3

nex3 added a commit to sass/dart-sass that referenced this issue Oct 25, 2023
@nex3
Add compatibility with Node.js 21.0.0
34fbe3c 
See dart-lang/sdk#53784. Although Node.js 21.1.0 fixed the issue on
its end, this release will use Dart 3.1.5 which will ensure we're
compatible even with the earlier release as well.
@nex3 nex3 mentioned this issue Oct 25, 2023
Merged
nex3 added a commit to sass/dart-sass that referenced this issue Oct 26, 2023
@nex3
Add compatibility with Node.js 21.0.0 (#2128)
89dac15 
See dart-lang/sdk#53784. Although Node.js 21.1.0 fixed the issue on
its end, this release will use Dart 3.1.5 which will ensure we're
compatible even with the earlier release as well.
@bricss
Copy link
Author

bricss commented Oct 28, 2023

Resolved ✅

@bricss bricss closed this as completed Oct 28, 2023
siimha added a commit to alphabill-org/alphabill-wallet-ui that referenced this issue Oct 31, 2023
@siimha
AB-1269 - Downgrade image node version
3981595 
dart-lang/sdk#53784
@fogodev fogodev mentioned this issue Nov 4, 2023
Merged
@they-cloned-me they-cloned-me mentioned this issue Dec 29, 2023
Closed
EDM115 added a commit to data-fair/app-charts that referenced this issue Jan 24, 2024
@EDM115
fix: correct data from axios, actual usage of plugins and fixed the s…
0062630 
…css issue

- the store is initialized in plugins/init.js like it was before, using the env object
- this env is set to empty if not retrieved
- import '../styles/settings.scss' is now valid, node 20 bug apparently, more info here :
  * vuejs/vitepress#3102
  * sass/dart-sass#2127
  * dart-lang/sdk#53784
- the data is set to data.data as soon as we get it from axios, removing further problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dart2js] Fix compatiblity with Node.js 21
5 participants
@nex3 @ntkme @sigmundch @bricss @lrhn