Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tests for FileSystemEntity.resolveSymbolicLinks failures in resolution. #53862

Closed
brianquinlan opened this issue Oct 25, 2023 · 2 comments
Closed

No tests for FileSystemEntity.resolveSymbolicLinks failures in resolution. #53862

brianquinlan opened this issue Oct 25, 2023 · 2 comments
Assignees
@brianquinlan
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. library-io P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@brianquinlan
Copy link
Contributor

It also does not test this case.
@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. library-io labels Oct 26, 2023
@brianquinlan brianquinlan added P3 A lower priority bug or feature request P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team and removed P3 A lower priority bug or feature request labels Nov 2, 2023
@a-siva
Copy link
Contributor

a-siva commented Jan 11, 2024

Is this a documentation issue ?

@brianquinlan
Copy link
Contributor Author

A documentation and test issue.

@brianquinlan brianquinlan changed the title FileSystemEntity.resolveSymbolicLinks does not document behavior if the link cannot be resolved No tests for FileSystemEntity.resolveSymbolicLinks failures in resolution. Jan 18, 2024
copybara-service bot pushed a commit that referenced this issue Jan 19, 2024
@brianquinlan
[io] Add tests for failure to resolve a path using `FileSystemEntity.…
e5f53ce 
…resolveSymbolicLinks`.

Bug:#53862
Change-Id: I269668064657856f2c2aa3479618b206aad075aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347204
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. library-io P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lrhn @a-siva @brianquinlan