Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] DevTools 2.28.3 #54085

Closed
kenzieschmoll opened this issue Nov 17, 2023 · 3 comments
Closed

[CP] DevTools 2.28.3 #54085

kenzieschmoll opened this issue Nov 17, 2023 · 3 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. cherry-pick-approved Label for approved cherrypick request

Comments

@kenzieschmoll
Copy link
Contributor

kenzieschmoll commented Nov 17, 2023 •
edited

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/336827

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/336827

Issue Description

  • flutter/devtools@265103e - This will allow us to run a better quality survey in early Q1 and reach users on stable. There was a bug that prevented links from working in VS code (including the link to open the survey) that is now fixed on the latest flutter stable.
  • flutter/devtools@e10051a - Copy does not work in VS code without this commit. This issue is severely affecting VS code user workflows and their DevTools sentiments
  • flutter/devtools@8efcaed - Prevents DevTools from inadvertently causing a crash on impeller.
  • flutter/devtools@5701174 - The new VS code sidebar that we shipped with Flutter stable was not respecting the user's IDE theme. This commit fixes that.
  • flutter/devtools@f9a77ce - This adds a link in the DevTools footer to the DevTools video that our Flutter DevRel team published in October. This will help with publicizing that work and will help address user feedback from survey that they need more tutorials.
  • flutter/devtools@276d7d9 - prevents an upstream bug causing links to be broken when DevTools is embedded in VS code

What is the fix

Release a cherry-pick release of DevTools into the Dart / Flutter SDKs that includes the above 6 commits.

Why cherry-pick

For issues and reasons why we selected each commit, see above.

Risk

low

Issue link(s)

flutter/devtools#6752

Extra Info

No response
@kenzieschmoll kenzieschmoll added the cherry-pick-review Issue that need cherry pick triage to approve label Nov 17, 2023
@mraleph mraleph added the area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. label Nov 20, 2023
@kenzieschmoll kenzieschmoll mentioned this issue Nov 20, 2023
Closed
@kenzieschmoll
Copy link
Contributor Author

kenzieschmoll commented Nov 21, 2023 •
edited

https://dart-review.googlesource.com/c/sdk/+/336827 CQ dry run has passed and @athomas has approved. Running Submit to CQ currently. [Edit: CL successfully merged]. When will this CP roll into the Flutter stable branch?

copybara-service bot pushed a commit that referenced this issue Nov 21, 2023
@kenzieschmoll
[stable] Cherry-pick DevTools 2.28.3
6d7f6f8 
Bug: #54085
Cherry-pick: flutter/devtools@v2.28.2...2.28.3
Cherry-pick-request: #54085
Fixes: #54085
Change-Id: If8e196f492b3f83b53882c8eb7949491a810a144
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336827
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
@kenzieschmoll kenzieschmoll mentioned this issue Nov 21, 2023
Merged
@athomas athomas added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Nov 22, 2023
@athomas
Copy link
Member

athomas commented Nov 22, 2023

Marking this as approved, it has already been merged.

@athomas
Copy link
Member

athomas commented Nov 22, 2023

Released in 3.2.1.

@athomas athomas closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. cherry-pick-approved Label for approved cherrypick request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mraleph @vsmenon @whesse @itsjustkevin @mit-mit @athomas @kenzieschmoll