Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] DevTools 2.28.4 #54213

Closed
elliette opened this issue Dec 1, 2023 · 2 comments
Closed

[CP] DevTools 2.28.4 #54213

elliette opened this issue Dec 1, 2023 · 2 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-tools A general category for issues that we think should be addressed by tooling. cherry-pick-approved Label for approved cherrypick request merge-to-stable

Comments

@elliette
Copy link
Contributor

elliette commented Dec 1, 2023

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/339227

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/339227

Issue Description

What is the fix

Release a cherry-pick release of DevTools into the Dart / Flutter SDKs that includes the above 3 commits.

Why cherry-pick

For issues and reasons why we selected each commit, see above.

Risk

low

Issue link(s)

flutter/devtools#6878

Extra Info

No response
@elliette elliette added the cherry-pick-review Issue that need cherry pick triage to approve label Dec 1, 2023
@jacob314
Copy link
Member

jacob314 commented Dec 4, 2023

LGTM
This is a high priority issue to fix.

@athomas athomas added merge-to-stable cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Dec 4, 2023
@lrhn lrhn added the area-tools A general category for issues that we think should be addressed by tooling. label Dec 5, 2023
copybara-service bot pushed a commit that referenced this issue Dec 5, 2023
@elliette
[stable] Cherry-pick DevTools 2.28.4
db5115c 
Bug: #54213
Cherry-pick: flutter/devtools@v2.28.3...2.28.4
Cherry-pick-request: #54213
Fixes: #54213
Change-Id: I266f0a02c8c88eb4d9735bc1e38d186c2d83ad82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339227
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
@athomas
Copy link
Member

athomas commented Dec 6, 2023

Released in 3.2.3.

@athomas athomas closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-tools A general category for issues that we think should be addressed by tooling. cherry-pick-approved Label for approved cherrypick request merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jacob314 @vsmenon @lrhn @itsjustkevin @mit-mit @athomas @elliette