Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] [Stable] Cherry pick request for 09da512b67d24d542468a61c28fc5ef2a53ae75b #54215

Closed
a-siva opened this issue Dec 2, 2023 · 6 comments
Closed

[CP] [Stable] Cherry pick request for 09da512b67d24d542468a61c28fc5ef2a53ae75b #54215

a-siva opened this issue Dec 2, 2023 · 6 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta merge-to-stable triaged Issue has been triaged by sub team

Comments

@a-siva
Copy link
Contributor

a-siva commented Dec 2, 2023

Commit(s) to merge

09da512

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/339345

Issue Description

new AOT snapshots in the SDK fail with SIGILL in ARM environments that don't support the integer division instructions

What is the fix

Consistently apply --target_unknown_cpu to AOT compilation

Why cherry-pick

We have some users that are observing a crash when running gen_snapshot

Risk

low

Issue link(s)

#54198

Extra Info

No response
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. cherry-pick-review Issue that need cherry pick triage to approve triaged Issue has been triaged by sub team labels Dec 2, 2023
@a-siva a-siva changed the title [CP] [stable] Cherry pick 09da512b67d24d542468a61c28fc5ef2a53ae75b into the stable channel [CP] [stable] Cherry pick reuest for 09da512b67d24d542468a61c28fc5ef2a53ae75b into the stable channel Dec 2, 2023
@a-siva a-siva changed the title [CP] [stable] Cherry pick reuest for 09da512b67d24d542468a61c28fc5ef2a53ae75b into the stable channel [CP] [Stable] Cherry pick reuest for 09da512b67d24d542468a61c28fc5ef2a53ae75b Dec 2, 2023
@a-siva a-siva changed the title [CP] [Stable] Cherry pick reuest for 09da512b67d24d542468a61c28fc5ef2a53ae75b [CP] [Stable] Cherry pick request for 09da512b67d24d542468a61c28fc5ef2a53ae75b Dec 2, 2023
@a-siva
Copy link
Contributor Author

a-siva commented Dec 2, 2023

//cc @rmacnak-google

@a-siva a-siva mentioned this issue Dec 4, 2023
Closed
@a-siva
Copy link
Contributor Author

a-siva commented Dec 4, 2023

//cc @itsjustkevin @athomas can we get approval for this cherry pick request, some Flutter users are also running into it, please see flutter/flutter#138693

@a-siva a-siva mentioned this issue Dec 4, 2023
Closed
@a-siva
Copy link
Contributor Author

a-siva commented Dec 4, 2023

approving change as it fairly low risk.

@a-siva a-siva added the cherry-pick-approved Label for approved cherrypick request label Dec 4, 2023
@athomas
Copy link
Member

athomas commented Dec 6, 2023

Released in 3.2.3.

@a-siva should we also CP this to beta? If yes, please add a CL for beta, if no, just close this issue.

@a-siva
Copy link
Contributor Author

a-siva commented Dec 7, 2023

@a-siva should we also CP this to beta? If yes, please add a CL for beta, if no, just close this issue.

Looks like the change missed the latest beta branch point which was 3.3.0-174.0.dev and so it would have to be cherry picked into the beta branch too. I will add a CL for beta today and update the issue accordingly.

@a-siva
Copy link
Contributor Author

a-siva commented Dec 7, 2023

I have created https://dart-review.googlesource.com/c/sdk/+/340286 for the cherry pick into the beta branch

copybara-service bot pushed a commit that referenced this issue Dec 11, 2023
@a-siva
[beta] [vm] Consistently apply --target_unknown_cpu to AOT compilation.
d269c3c 
 - Fixes new AOT snapshots in the SDK failing with SIGILL in ARM environments that don't support the integer division instructions.
 - Likewise fixes snapshot generated by `dart compile exe`.

TEST=local QEMU

Bug: #54198
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/339104
Cherry-pick-request: #54215
Change-Id: I6acf65d6064c8aeebc9957e7e13720406f315fef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340286
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
@itsjustkevin itsjustkevin added the cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. label Dec 11, 2023
@christopherfujino christopherfujino mentioned this issue Jan 10, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta merge-to-stable triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas