[ddc] Implement declaration site variance in the new runtime type system #54367
Assignees
Labels
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
web-dev-compiler
Comments
nshahan
added
web-dev-compiler
area-web
copybara-service bot
pushed a commit
that referenced
this issue
Dec 22, 2023
Moving variance to `js_shared/lib/variance.dart` so we can use the same synced indices when marking variance in both dart2js and ddc. This avoids needing to sync multiple data structures that all represent variance. Bug: #54367 Change-Id: Ia6fda84decd43374c08ed3bd0d0b240071310d9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341840 Reviewed-by: Mayank Patke <fishythefish@google.com> Commit-Queue: Kallen Tu <kallentu@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The feature is currently working in the old runtime type system but tests in the
language/variancesuite are failing on ddc-canary configurations.This will soon become the stable version of DDC so the tests will be failing on all DDC configurations.
The text was updated successfully, but these errors were encountered: