Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting flag pause_isolates_on_start does not pause isolates on hot-restart #54900

Closed
elliette opened this issue Feb 12, 2024 · 1 comment
Closed

Setting flag pause_isolates_on_start does not pause isolates on hot-restart #54900

elliette opened this issue Feb 12, 2024 · 1 comment
Assignees
@bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team vm-service The VM Service Protocol, both the specification and its implementation

Comments

@elliette
Copy link
Contributor

The VM Service allows clients to set pause_isolates_on_start at runtime:

Here's an example of doing so in Dart DevTools:

However, with that change, the isolates are not paused on hot-restart.

Steps to repro:

  • patch the change into DevTools
  • run DevTools and connect to an app
  • trigger a hot-restart from DevTools
  • isolates do not start paused

Expected result: isolates should start paused

FYI @bkonyi
@elliette elliette added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. vm-service The VM Service Protocol, both the specification and its implementation labels Feb 12, 2024
@elliette elliette mentioned this issue Feb 12, 2024
Merged
@bkonyi bkonyi self-assigned this Feb 14, 2024
@bkonyi bkonyi added P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team labels Feb 14, 2024
@elliette elliette mentioned this issue Feb 15, 2024
Closed
14 tasks
@bkonyi
Copy link
Contributor

bkonyi commented Apr 22, 2024

It appears this was a bug in DevTools (if I'm not mistaken) so I'm going to close this. Feel free to re-open if this is still an issue.

@bkonyi bkonyi closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team vm-service The VM Service Protocol, both the specification and its implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliette @bkonyi