Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check exceptions during json serialization during dry run #55287

Closed
knopp opened this issue Mar 23, 2024 · 1 comment
Closed

Null check exceptions during json serialization during dry run #55287

knopp opened this issue Mar 23, 2024 · 1 comment

Comments

@knopp
Copy link
Contributor

knopp commented Mar 23, 2024

CBuilder does not set architecture during dry run but it seems to be required during serialization:

Null check operator used on a null value
#0      NativeCodeAssetImpl.toJson (package:native_assets_cli/src/model/native_code_asset.dart:342:62)
#1      BuildOutputImpl.toJson (package:native_assets_cli/src/model/build_output.dart:96:46)
#2      BuildOutputImpl.toJsonString (package:native_assets_cli/src/model/build_output.dart:105:50)
#3      BuildOutputImpl.writeToFile (package:native_assets_cli/src/model/build_output.dart:155:24)
#4      build (package:native_assets_cli/src/api/build.dart:95:16)
<asynchronous suspension>

DynamicLoadingBundledImpl has permitted to have no file URI during dry run (which is good, as on Rust the location depends on architecture for example), but it fails during serialization:

Null check operator used on a null value
#0      DynamicLoadingBundledImpl.toJsonV1_0_0 (package:native_assets_cli/src/model/native_code_asset.dart:93:43)
#1      NativeCodeAssetImpl.toJson (package:native_assets_cli/src/model/native_code_asset.dart:341:21)
#2      BuildOutputImpl.toJson (package:native_assets_cli/src/model/build_output.dart:96:46)
#3      BuildOutputImpl.toJsonString (package:native_assets_cli/src/model/build_output.dart:105:50)
#4      BuildOutputImpl.writeToFile (package:native_assets_cli/src/model/build_output.dart:155:24)
#5      build (package:native_assets_cli/src/api/build.dart:95:16)
@knopp
Copy link
Contributor Author

knopp commented Mar 23, 2024

Closing in favor of dart-lang/native#1053

@knopp knopp closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant