[dart2wasm] Compiler ignores library annotation for unwrapped functions

[ykmnkmi]

@JS('__test__')
library;

import 'dart:js_interop';

@JS('__log__')
external T log1<T extends JSObject>(T object);

@JS('__log__')
external T _log<T extends JSObject>(T object);

T log2<T extends JSObject>(T object) {
  return _log<T>(object);
}

const dart2wasm = {
  // log1(), incorect
  _123: x0 => globalThis.__log__(x0),
  // log2(), correct
  _13050: x0 => globalThis.__test__.__log__(x0)
};

Dart SDK version: 3.5.0-edge.8ca97716cc5f1be89eebd5a79a8f0daa541fd55c (main) on "windows_x64".

[osa1]

I don't think the repro is right, could you provide a full example with repro commands?

In your example _log and log1 are identical other than the function name so they can't generate different imports in the .mjs file.

log2 won't generate an import as it's not annotated with @JS, so the comments in your .mjs snippet are not right.

[ykmnkmi]

@osa1 I still don't know when it happens, this repro works right now:

// web/main.dart
import 'dart:js_interop';

import 'package:app/a.dart';

import 'test.dart';

void main() {
  print(log1(JSObject()));
  print(log2(JSObject()));
}

// lib/a.dart
export 'package:app/src/a.dart';

// lib/src/a.dart
@JS()
library;

import 'dart:js_interop';

For bigger example try to remove wrappers here:

wasm.mp4

(video link fix)

[srujzs]

I think this is related to how we cache method calls in our interop specializers, which might be why you see the issue appear when you remove a call, because that may lead to slightly different interop generation. I also think this code might be contributing to why you're seeing the missing prefix: we use the current library's annotation prefix instead of the interop member's enclosing library's annotation prefix. This shouldn't be an issue due to how we generate procedures, but there's probably a bug somewhere. I'll do some more digging. Can you share the full contents of test.dart? Is it just the above interop code?

[ykmnkmi]

@srujzs yes, first example.

[srujzs]

https://dart-review.googlesource.com/c/sdk/+/361241 should fix this:

const dart2wasm = {
_261: x0 => globalThis.__test__.__log__(x0),
_262: x0 => globalThis.__test__.__log__(x0)
}

[ykmnkmi]

@srujzs thanks.