Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart editor - need to distinguish multiple duplicate classes in statement completion list #564

Closed
DartBot opened this issue Nov 22, 2011 · 4 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Nov 22, 2011

This issue was originally filed by mattsh@google.com


If I type
Element
and then ctrl-space,

I see two classes named Element in the statement completion dropdown. An unrelated bug is why we have two interfaces named Element in this list. But separate from that, the issue here is that there's no way to see why there are two. It would be good if the list would give the library name (in parentheses) when there are multiple classes with the same name, so there is at least some way to understand why there are two interfaces with the same name.

@bwilkerson
Copy link
Member

I suspect that the problem is that the list is not yet being trimmed to only show those names that are visible in scope, but instead shows all known names. Showing all possible names is not necessarily bad, but those that are in scope should at least come first in the list.

As either an alternative or in addition to the original suggestion we might want to display names that need to be qualified by a prefix in fully qualified form.

@clayberg
Copy link

clayberg commented Mar 6, 2012

Please check this and close if no longer an issue.


Set owner to @bwilkerson.

@DartBot
Copy link
Author

DartBot commented Apr 9, 2012

This comment was originally written by mattsh@google.com


This is still an issue. For example, typing "D" and then ctrl-space, you see two entries for "Database", and nothing distinguishes why there are two. Or, if you type "X", you see two entries for "XMLHttpRequest", etc.

@clayberg
Copy link

clayberg commented May 2, 2012

Works for me in the latest build. Re-open if this crops up again.


Added Fixed label.

nex3 pushed a commit that referenced this issue Aug 31, 2016
we still have an init method, for better or worse, to break out of ES6 restrictions

The idea here is default Dart constructor (really an initialization method) is always called `new` instead of the class name. We already do this for unnamed factory.

R=leafp@google.com

Review URL: https://codereview.chromium.org/1965213003 .
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants