Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing jQuery's hide() functionality #6526

Closed
DartBot opened this issue Nov 5, 2012 · 7 comments
Closed

Missing jQuery's hide() functionality #6526

DartBot opened this issue Nov 5, 2012 · 7 comments
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Nov 5, 2012

This issue was originally filed by @sethladd


If dart:html is supposed to be the jQuery for Dart, we're missing quite a lot. I just answered http://stackoverflow.com/questions/13223840/dart-js-interop-callbacks which wanted to hide().

Here is the doc for hide(): http://api.jquery.com/hide/

Bigger question, do we want to sweep through jQuery and catalogue what we want to add to dart:html ?

@DartBot
Copy link
Author

DartBot commented Nov 5, 2012

This comment was originally written by @a14n


For that functionnality, what about using a "visible" property. Something like :

class Element {
bool get visible => style.display != 'none';
set visible(bool visible) => style.display = visible ? '' : 'none';
}

@DartBot
Copy link
Author

DartBot commented Nov 5, 2012

This comment was originally written by kaisellgren@gmail.com


We might also want to consider a toggle() method as well, which checks the visibility and hides / shows accordingly.

Also, hiding and showing can be achieved either by changing visibility or entirely collapsing the element. I suppose collapsing is the default behavior we should use and possibly provide a parameter to specify the other way.

@sethladd
Copy link
Contributor

sethladd commented Nov 5, 2012

Removed Type-Defect label.
Added Type-Enhancement, Area-HTML, Triaged labels.

@efortuna
Copy link
Contributor

efortuna commented Dec 6, 2012

Added this to the Later milestone.

@DartBot
Copy link
Author

DartBot commented Mar 19, 2013

This comment was originally written by amouravski@google.com


Added Duplicate label.
Marked as being merged into #8376.

@DartBot
Copy link
Author

DartBot commented Apr 13, 2013

This comment was originally written by Ben.Tre...@gmail.com


The Element.hidden property does not work in IE9. Are we going to stand there pointing at IE or are we going to shim it?

@blois
Copy link
Contributor

blois commented Apr 15, 2013

I opened bug 9900 for the Element.hidden property.

@DartBot DartBot added Type-Enhancement web-libraries Issues impacting dart:html, etc., libraries closed-duplicate Closed in favor of an existing report labels Apr 15, 2013
@DartBot DartBot added this to the Later milestone Apr 15, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

5 participants